Cannot opt out buttons using #gin_action_item = TRUE

I can confirm this behavior. When using 3.0.0-rc13 everything works fine.

I created a merge request with 2 changes. One restore the check for #gin_action_item value. If it has a truthy value, the the button will not be added to the more actions group.

The other change about checkint the #access flag. I found that, (when i using workflow or workflow_buttons) the Preview button always visible even if I set the "Preview before submitting" value to "Disabled".

Ah fantastic fix for the Preview button i thought i was losing another bit of my mind!

Confirmed that the restore of #gin_action_item setting works also. Excellent fixes, thanks!

Code changes are simple and clear. Curious if an alter hook or other API would be a more consistent way of keeping but that is a different issue and it really it does not matter so long as it is documented: 📌 Document clearly how contrib modules and/or site builders determine which content form buttons are primary Active

Thanks so much for creating this MR. Gin is sometimes a bit too opinionated :/

Unfortunately, due to the way that these buttons are now placed in the sticky header, by creating a new <label> tag, this breaks setups with more fancy custom buttons, e.g. with ajax behaviours attached.
Not sure if this issue should address that too.

Changes in the PR work well for me.

Thanks for the fix, this certainly was a regression.

@berliner the sticky actions is no easy task. We're working on some improvements in 📌 Improve sticky actions implementation Active

I applied this patch but the #gin_action_item flag isn't working for me. The Preview button is hidden now as expected.

@heatherwoz Could you give more details? Where do you set the #gin_action_item = TRUE? What is happening? Is your button displayed in the More action dropdown or is it visible at all?

I also have the same issue as @heatherwoz. We are using the Content lock module and an issue has been raised 💬 "Unlock" button is hidden behind a "More actions" dropdown in the Gin Admin theme Active there with the fix applied but still the unlock button is missing. If I move the admin theme back to Claro the button appears again

I am trying to make the cancel button visible at all times, so that it is easy for users to click. I have this in the code and I see it is being added to the form, but it still shows in the dropdown and not as a separate button:

    // Move cancel to be a gin action item.
    if (isset($form['actions']['cancel'])) {
      $form['actions']['cancel']['#gin_action_item'] = TRUE;
    }

'#gin_action_item' only applies on '#type' == 'submit' elements inside 'actions' container. It used to work on any types before rc14, like the 'delete' modal link.

Here is a patch that applies the same logic to all other types in the else statement.

Automatically closed - issue fixed for 2 weeks with no activity.

I'm experiencing the same thing a @heatherwoz & @paulguy: #gin_action_item does not work for non-submit buttons.

Since this issue can't be reopened, I've cross-posted @paulguy's patch on that 💬 Feeds Save and import button missing when sticky action buttons setting enabled Active where this problem is also called-out.

Hi paulguy,

I have the same problem, on two 'link' type buttons. I want to make them appear in the sticky actions. Patching a production site isn't necessarily ideal. Is there another solution or a hook for this?

Thanks.