Account created on 6 November 2007, over 16 years ago
#

Merge Requests

Recent comments

πŸ‡©πŸ‡ͺGermany berliner

No feedback and it fixes the issue for me, so I have merged this.
Feel free to re-open if the problem persists at your end.

πŸ‡©πŸ‡ͺGermany berliner

Good catch. I think that's curtesy of πŸ› Breaks resizing of uploaded images in ckeditor Fixed . Can you test if the MR fixes the issue for you?

πŸ‡©πŸ‡ͺGermany berliner

For discussion: Maybe something like this patch, which allows to opt-out of the gin breadcrumb processing doing this:

/**
 * Implements hook_preprocess_breadcrumb().
 */
function MY_MODULE_preprocess_breadcrumb(&$variables) {
  $node = \Drupal::routeMatch()->getParameter('node');
  if ($node->bundle() == 'MY_BUNDLE') {
    $variables['gin_breadcrumb_skip'] = TRUE;
  }
}
πŸ‡©πŸ‡ͺGermany berliner

The problem with this as far as I can see, is that whatever custom breadcrumb one puts in place, gin_preprocess_breadcrumb() will just overwrite it for all routes where an entity object can by extracted by _gin_get_route_entity().

So this doesn't look like a feature request, but more like a support request. It would be good to be able to opt-out of this behaviour on the gin side. The way it is right now feels a bit greedy.

Or is there already a way to opt out of this that I just didn't see?

πŸ‡©πŸ‡ͺGermany berliner

I have updated the MR with the patch and a minor correction for backwards compatibility.

I'll also add a patch file that works for 8.x-1.3.

πŸ‡©πŸ‡ͺGermany berliner

The patches have been a bit greedy though. Instead of only moving the form action submit buttons and button links into the dialogs button pane, it now moves all submit buttons and button links there.
So it's now doing exactly what it was meant not to do, according to this comment: https://git.drupalcode.org/project/layout_paragraphs/-/commit/9e6ce29756...

I have raised πŸ› Dialog form button logic is too greedy Active as a follow-up issue to fix this.

πŸ‡©πŸ‡ͺGermany berliner

The performance concern raised in #10 was about the patch in #5, which only changed the urls inside the srcset without also adapting the logic in ImageStyleDownloadController, so I don't see how that would still be an issue with the current patch.

πŸ‡©πŸ‡ͺGermany berliner

Updated patch from #38 for rc10. I hope I didn't miss anything.
I don't have the capacities right now to look at the MR unfortunately.

Still setting to "Needs work" to check if the MR needs modifications to be applied to the current dev.

πŸ‡©πŸ‡ͺGermany berliner

I personally appreciate the patche files from saurabh rawat to have something usable in D10.2.

πŸ‡©πŸ‡ͺGermany berliner

This works great and fixes the "Edit [term name]" on taxonomy pages as well. Just tested the last patch file but didn't look at the MR.

πŸ‡©πŸ‡ͺGermany berliner

This patch hides the "Add child" link from a terms entity operations if the vocabulary is set to use flat taxonomy.

πŸ‡©πŸ‡ͺGermany berliner

I get the feeling that this get's a bit out of hand here.
Those last patches do not seem to address the original issue about the changed button ids and the outdated references in the ajax subsystem. #12 should fix the issue as demonstrated by the "steps to reproduce", so this should be reviewed and tested. The other patches seem to be about different issues. Maybe it would be better to create a new issue for those with sufficient information to reliably reproduce the problems and then fixing them.

πŸ‡©πŸ‡ͺGermany berliner

Good catch. Thanks for the MR. Merged just now.

πŸ‡©πŸ‡ͺGermany berliner

berliner β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany berliner

Rerolled #3 for rc9.

I would be in favour of not changing the ids in the first place though, just as hudri suggested. Removing unnecessary complexity is always preferable.

πŸ‡©πŸ‡ͺGermany berliner

This overflow issue somehow appeared again in rc8 on D 10.2. I didn't have time to investigate further at the moment, but the "table { width: 100% }" fix worked in my use case again, ignoring issues with table overflowing the page content horizontally.

πŸ‡©πŸ‡ͺGermany berliner

This seems to have been fixed in the meantime.

πŸ‡©πŸ‡ͺGermany berliner

Thanks @ultrabob. But this issue is about a missing listing page for "trashed" content, using the soft-delete feature of this module. I am able to see the worflow buttons. But the link to the trash leads to a 404.
Note: I'm not using the module for my project after all, so I won't be able to provide further details.

πŸ‡©πŸ‡ͺGermany berliner

Found an issue with the patch. The ProxySubscriber redirected to a non-valid URL. The attached patch fixes that.

πŸ‡©πŸ‡ͺGermany berliner

This is a re-roll of #8, which sounds like the better approach compared to #9 which removed the config part (form and schema). Patch applies to current dev and to 8.x-1.6. Seems to work as expected.

πŸ‡©πŸ‡ͺGermany berliner

I misread the last post and didn't look at the patch in detail, so I thought the update hooks were still missing.
Sorry for that.

πŸ‡©πŸ‡ͺGermany berliner

@Anybody The steps to reproduce from the issue description don't help you isolate the problem? It took me a while, but in the end I was able to reliably reproduce this issue in my setup.

πŸ‡©πŸ‡ͺGermany berliner

Drupal 9.4 is no longer supported, please upgrade to Drupal 9.5 or Drupal 10 which require PHP 8.1 or higher. PHP 7.4 is end of life since already and is not supported anymore.
The reported issue is due to PHP syntax not supported in PHP 7.4.

πŸ‡©πŸ‡ͺGermany berliner

Which version of Drupal and PHP are you running?

πŸ‡©πŸ‡ͺGermany berliner

Adding a schema file.

πŸ‡©πŸ‡ͺGermany berliner

Re-rolled for current dev.

πŸ‡©πŸ‡ͺGermany berliner

Updated patch with minor improvements and added tests.

πŸ‡©πŸ‡ͺGermany berliner

Thanks for looking at coding standards!

πŸ‡©πŸ‡ͺGermany berliner

berliner β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany berliner

I see this problem in Layout Paragraphs when the Gin admin theme in version 8.x-3.0-rc1 is used. It sets the --ck-z-modal to 98 for all ck classes. Updating to 8.x-3.0-rc2 fixes the issue.

πŸ‡©πŸ‡ͺGermany berliner

@urvashi_vora There is no difference between your MR and the patch in #3, correct?

πŸ‡©πŸ‡ͺGermany berliner

@tyler36 The WebP module seems to go down the same route though, with only a beta release, the last commit from 15 Jan, 2022 being older than a year now too and no visible activity from the maintainers anymore.

πŸ‡©πŸ‡ͺGermany berliner

Bumping the priority, because this issue breaks the module.

πŸ‡©πŸ‡ͺGermany berliner

Looks good, makes sense and fixes the issue.

πŸ‡©πŸ‡ͺGermany berliner

Fixes the issue and simple enough to RTBC I guess.

πŸ‡©πŸ‡ͺGermany berliner

This patch should fix that.

πŸ‡©πŸ‡ͺGermany berliner

That was too quick and not properly tested. This one is fixing the issue for me.

πŸ‡©πŸ‡ͺGermany berliner

Thanks @saschaeggi. That change works for me without the width: auto; on the table and fixes the issue.
I couldn't test the scenario described by @tea.time though.

πŸ‡©πŸ‡ͺGermany berliner

Wasted time :( So it seems to be an issue with Chromium based browsers, which apparently don't like it if the id of input changes that had previously been bound by the Drupal.Ajax logic. I have reached my horizon here, and given that it is limited to chromium and browser based on that, I'll be going to ignore this issue for now.

πŸ‡©πŸ‡ͺGermany berliner

Having implemented my own version of previewer, not aware that the module existed, I have just run into this now when switching the backend theme from Claro to Gin for one of my projects. While trying to see what breaks the ajax on the preview button, I have also installed the previewer module and tested with every single release of Gin since alpha33, which is the last version where both the previewer module and my custom implementation worked.

So this issue does not seem to have been solved actually. Using the current rc1, I can confirm that code attaching an ajax event to the node edit preview button (using #ajax

I'll try to debug this further to find the issue.

πŸ‡©πŸ‡ͺGermany berliner

@tea.time Outch, good catch. It's true, I didn't test that scenario at all, just wanted to get rid of the overflow quickly. Too quickly ..

πŸ‡©πŸ‡ͺGermany berliner

Setting the table to `width: auto;` seems to fix it for me.

In the rc, the width calculation doesn't happen on the full table, but on the individual columns instead. This has been done in πŸ“Œ [JS Refactor] tableselect / tableheader Fixed .

From what I can see, also using Horizontal, Modern Toolbar (though no idea if related or not), the table inherits `width: 100%` from claro, which makes it span too wide. Setting that to `width: auto` (via `table.sticky-header { width: auto; }` constraints the table to the cumulative width of the (correctly calculated) column widths.

πŸ‡©πŸ‡ͺGermany berliner

Anyone else coming here looking the reason for the sticky header being too wide, as described first in #7: offending "submit" link β†’ , setting the table to `width: auto;` seems to fix it for me.

πŸ‡©πŸ‡ͺGermany berliner

Re-rolled and re-targeted for 4.0.x.

πŸ‡©πŸ‡ͺGermany berliner

As mentioned by @byrond, this seems to have been fixed in 6.0.x by this commit in πŸ› sync option doesnt work with track_changes Fixed .

πŸ‡©πŸ‡ͺGermany berliner

Looks like this feature made it into the 2.0.x branch, yeah!!

Production build 0.69.0 2024