Contrib.social

Hide "Add child" link from entity operations

Open on Drupal.org →
Created on 13 March 2024, over 1 year ago

Problem/Motivation

When enabling flat taxonomy on a vocabulary, we can still see the "Add child" link in entity operation links and reach a page with a pre-filled parent field, even though it's hidden. Only when submitting the form, there is an error message and the term can't be saved. So validation is working good, but it would be better to hide (a) the link "Add child" and/or (b) prevent access to the term add form when a parent is given as a query argument.

Steps to reproduce

- create a vocabulary and enable flat taxonomy
- create a term in that vocabulary
- go to the term listing page of that vocabulary and see under "Operations" that there is an "Add child" link

Proposed resolution

Remove the "Add child" link from the entity operations for terms from vocabularies using flat taxonomy.

Remaining tasks

Patching and testing

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇩🇪Germany berliner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @berliner
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇩🇪Germany berliner

    This patch hides the "Add child" link from a terms entity operations if the vocabulary is set to use flat taxonomy.

  • Status changed to RTBC 10 months ago
  • Comment 10 months ago →
    🇪🇸Spain plopesc Valladolid

    Patch looks good and works well for us.

    Marking as RTBC

  • Comment 5 days ago →
    🇺🇸United States mlncn Minneapolis, MN, USA

    Confirming the code quality and functionality of this patch. Also think that it is the right solution, and a good one. In particular for a vocabulary where a user does not have edit permissions for the terms, the inapplicable operation link to "Add child" is very in-the-face and distracting.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024