- Issue created by @drclaw
- 🇨🇦Canada drclaw
Patch converts $this->routeMatch->getParameter('page_manager_page_variant'); to $this->request->attributes->get('_page_manager_page_variant'); per above
🙏
- 🇩🇪Germany berliner
Thanks for raising this issue drclaw!
While I generally agree with the patch, I'm just a bit confused how you encountered this issue. Looking quickly, I couldn't find anything that's actually broken due to the changes in page manager rc3 and my understanding is that even if
$this->routeMatch->getParameter('page_manager_page_variant')
(/src/LayoutBuilderIpeService.php?ref_type=heads#L476) fails, the call to$this->getEntity()
in /src/LayoutBuilderIpeService.php?ref_type=heads#L488 provides a fallback (which actually looks at the request attributes just as you propose).So for my own curiosity: Can you describe what is actually broken before this change?
-
berliner →
committed 515b2b9c on 1.0.x
Issue #3484742 by drclaw: Updates for latest page_manager release 8.x-4....
-
berliner →
committed 515b2b9c on 1.0.x
Automatically closed - issue fixed for 2 weeks with no activity.