The containers summary text should not be overwritten

Created on 15 November 2023, 12 months ago

Updated 16 November 2023, 12 months ago

Problem/Motivation

ImageWidgetCrop.js currently hardcodes the text to be used for the container summary to 'Crop image', even though the ImageCrop form element could be altered/extended to use a different title.

Proposed resolution

Don't hardcode the summary text in ImageWidgetCrop.js but retrieve the initial text from the rendered markup instead.

🐛 Bug report

Status

Needs review

Version

2.0

Component

User interface

Created by

🇩🇪Germany berliner

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @berliner
Status changed to Needs review 12 months ago10:16pm 15 November 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 12 months ago
4 pass
Comment 12 months ago →
🇩🇪Germany berliner
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 12 months ago
4 pass
Comment 12 months ago →
🇮🇳India mukhtarm
Tested the patch and its working fine. I guess in that case we can remove the hardset initilization too.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024