Add D11 compatibility

Created on 17 October 2024, 6 months ago

This module needs to be made compatible with D11

Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium flyke

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @flyke
  • 🇧🇪Belgium flyke

    Testing if this works by simply changing the core_version_requirement in the info yml file.

  • 🇩🇪Germany berliner

    According to the test runner I would expect issues: https://git.drupalcode.org/project/layout_builder_ipe/-/jobs/2793314

  • 🇧🇪Belgium flyke

    If anyone needs to add this module to a D11 project, here are instructions if you have not done it before.

    Add the patch in your composer.json patches section.

                "drupal/layout_builder_browser": {
                    "#3431577": "https://git.drupalcode.org/project/layout_builder_browser/-/merge_requests/23.diff"
                }

    If you don't have composer-drupal-lenient yet, add it to your project first:
    composer require mglaman/composer-drupal-lenient

    If your minimum stability is not set to dev yet, you need to do that first:
    composer config minimum-stability dev

    Add this module to the lenient allowed list:
    composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/layout_builder_ipe"]'

    Now you can add this module to your D11 project:
    composer require drupal/layout_builder_ipe

    And of course you can enable it
    drush en layout_builder_ipe

  • 🇩🇪Germany berliner

    I have tagged 1.0.0-alpha10 as a new release which adds support for Drupal 11.
    https://git.drupalcode.org/project/layout_builder_ipe/-/commit/082df0767...

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 3 months ago
  • 🇧🇪Belgium flyke

    I updated my project to D11.1 and I could no longer use this module to edit the page.
    JS error:

    Uncaught TypeError: Cannot read properties of undefined (reading 'message')
        at Drupal.behaviors.lb_ipe_attach_behaviors.attach.$ajax_link.get.options.error (ipe.js?v=11.1.1:82:67)
        at c (jquery.min.js?v=4.0.0-beta.2:2:23212)
        at Object.fireWith [as rejectWith] (jquery.min.js?v=4.0.0-beta.2:2:23973)
        at E (jquery.min.js?v=4.0.0-beta.2:2:69804)
        at XMLHttpRequest.<anonymous> (jquery.min.js?v=4.0.0-beta.2:2:72283)

    If I disable this module and just use layoutbuilder to edit the page, that works fine.

  • 🇩🇪Germany berliner

    Which version of this module are you using? Did you try with the dev branch?

  • 🇩🇪Germany berliner

    I just installed this module in a fresh Drupal CMS and it seems to work just fine. Can you give me more information about your setup?

    Also, the error indicates that an empty / undefined json response for an ajax call. Are you able to identify the request that fails? Do you see any 500 errors in your logs by any chance? Or anything else in the web server or PHP logs that could help me identify the issue?

  • 🇧🇪Belgium flyke

    I tested layout_builder_ipe 1.0.0-beta10 on a D11 project and it works well.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024