Contrib.social

Fix issues reported by Stylelint

Open on Drupal.org →
Created on 8 July 2024, 10 months ago

Problem/Motivation

With the integration of GitLab CI from 📌 Add Gitlab CI to V2 of the module Active there is now a report for Stylelint issues at https://git.drupalcode.org/project/activecampaign/-/jobs/2058691

STYLELINT version 15.11.0
$ $CI_PROJECT_DIR/$_WEB_ROOT/core/node_modules/.bin/stylelint --ignore-path ./.stylelintignore --formatter verbose --config $CI_PROJECT_DIR/$_WEB_ROOT/core/.stylelintrc.json ./**/*.css --color $_STYLELINT_EXTRA || true
modules/activecampaign_dashboard/css/admin-menu.css
  6:1   ✖  Delete "⏎"                                                                      prettier/prettier
  7:61  ✖  Expected double colon pseudo-element notation                                   selector-pseudo-element-colon-notation
  8:25  ✖  Replace "'../images/activecampaign.svg'" with ""../images/activecampaign.svg""  prettier/prettier
 11:67  ✖  Expected double colon pseudo-element notation                                   selector-pseudo-element-colon-notation
 12:25  ✖  Replace "'../images/activecampaign.svg'" with ""../images/activecampaign.svg""  prettier/prettier
 15:23  ✖  Replace "·.toolbar·.toolbar-bar" with "⏎··.toolbar⏎··.toolbar-bar⏎·"            prettier/prettier
 15:84  ✖  Expected double colon pseudo-element notation                                   selector-pseudo-element-colon-notation
7 problems (7 errors, 0 warnings)
1 source checked
 /builds/project/activecampaign/web/modules/custom/activecampaign/modules/activecampaign_dashboard/css/admin-menu.css
7 errors found
 prettier/prettier: 4
 selector-pseudo-element-colon-notation: 3 (maybe fixable)

Steps to reproduce

https://git.drupalcode.org/project/activecampaign/-/jobs/2058691

Proposed resolution

Fix the issues and create a merge request.

Review the changes and merge the MR.

Remaining tasks

Add code and review the changes.

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇧🇪Belgium dtfabio Ninove

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024