- Issue created by @fenstrat
- Status changed to Needs review
over 1 year ago 5:37am 26 April 2023 - π¦πΊAustralia fenstrat Australia
Attached implements approach number 2.
- πΊπΈUnited States johnpicozzi Providence, RI
Looks like this patch needs to be re-rolled to apply cleanly.
- First commit to issue fork.
- Status changed to RTBC
about 1 year ago 4:43pm 1 November 2023 - π©πͺGermany triple5
Thank you for seeing to this issue, however,
I do not understand the differences between patches
remove-dependency-on-ckeditor-3356461-6.patch
and
3356461-2.patch
Also, I would suggest, that we require it to be drupal core Version ^9.3 || ^10 since there is no ckeditor5 in core before that:
- core_version_requirement: ^8 || ^9 || ^10
+ core_version_requirement: ^9.3 || ^10
Now probably the more stupid part of my comment:
Still I do not understand how to apply either patch to my site, when I just remove the line from the fakeobjects.info.yml I still have the dependencycomposer why drupal/ckeditor drupal/fakeobjects 1.2.0 requires drupal/ckeditor (*)
- πΊπΈUnited States generalredneck
triple5,
So any changes made to composer.json doesn't take affect when you patch a module because those changes aren't part of the drupal.org packagist. You won't see that change until this patch gets committed into a branch that has a release associated with it or you do some work to either define a custom package that looks like the changed composer.json or commit the composer.json changes into a repo (forking the module) and pointing a repository entry to that.
To try to make it more clear, a packagist consumes a composer.json file to build a package entry (you can see the one for this module at https://packages.drupal.org/files/packages/8/p2/drupal/fakeobjects.json). When it gets to your machine after you download the code, you then patch it. So it's not even considered.
- First commit to issue fork.
- π¨π¦Canada xmacinfo Canada
I am available to be a maintainer of this module and create a new release.
This is RTBC and we have an agreement.
- πΊπΈUnited States generalredneck
xmacinfo,
Consider going through this process β . - π§πͺBelgium ΓΈkse
Patch from #6 doesn't apply so I had to re-roll this against the latest version.
- π¦πΊAustralia mstrelan
Not sure if this is still necessary since anchor_link no longer has the dependency on fakeobjects. Are there other CKE5 modules that use fakeobjects?
- π¬π§United Kingdom andreastkdf
https://www.drupal.org/project/footnotes β is another CKE5 module that uses fakeobjects
- Status changed to Fixed
6 months ago 1:58pm 6 July 2024 - π¨π¦Canada xmacinfo Canada
Merged niklp branch to the dev branch.
Thanks.
Automatically closed - issue fixed for 2 weeks with no activity.