🇨🇦Canada @xmacinfo

“Skip to links” targets are missing:

<div id="skip-link" tabindex="-1">
  <a href="#main-content" class="visually-hidden focusable">
    Skip to main content
  </a>
  <a href="#search-block-form" class="visually-hidden focusable skip-link-search">
    Skip to search
  </a>
</div>

Since the design does not have a search form, the “Skip to search” link should be removed.

The “Skip to main content” link should instead target “#block-bluecheese-content” as “#main-content”. Or, alternatively, the “#block-bluecheese-content” div should be renamed to “#main-content”.

Still on Drupal 7

https://jobs.drupal.org will not be secure after January 5th, 2025.

<meta name="Generator" content="Drupal 7 (http://drupal.org)">

Secure

https://api.drupal.org/

Drupal.org not secure after January 5, 2025

It was written in the sky. The most important pages of Drupal.org will not be secure after January 5th, 2025.

Drupal.org pages related to modules and accounts are still using Drupal 7:

If the security teams abandons support for Drupal 7 January 5th, we should not trust using Drupal.org, even tough the login process migrated away from Drupal 7. The most important pages of Drupal are still on Drupal 7, including user profiles.

If the Drupal 7 used on Drupal.org gets security fixes, those fixes should be offered for free and a new version of Drupal 7 should be released.

New.Drupal.org

Note that this does not affect the new pages built for the https://new.drupal.org running on Drupal 10. Those pages are mostly hosting a new site running on Drupal 10 with many redirections to the Drupal 7 site.

In other words, a new frontend built on Drupal 10 with a new theme with a not secure Drupal 7 backend.

Currently, only a few pages have been created (not migrated) on Drupal 10 and they are visible with the “new” prefix:

https://new.drupal.org/

All the main functionalities of Drupal.org are still on Drupal 7.

<meta name="generator" content="Drupal 7 (https://www.drupal.org)" />

This means that the most important pages of Drupal.org will not be secure after January 5th, 2025.

xmacinfo → created an issue.

xmacinfo → created an issue.

xmacinfo → created an issue.

xmacinfo → created an issue.

Marking this issue as a duplicate.

@rahul17 Let's split the gitlab-ci in another ticket. Also, if there are no code change, we will keep Drupal 8 support.

What I can do is merge !8, not !7.

Your patch does not work.

@w01f: Thanks for trying out xClaro. But note that in xClaro I am not using the same dark colours as we can see in the draft mock-up displayed in comment #12. The official dark colours of Claro should be defined by the Claro maintainers, and, hopefully, developed and release before we hit Drupal 12.

xmacinfo → created an issue.

xmacinfo → created an issue.

xmacinfo → created an issue.

I like very much seeing all the new drupal.org look running on top of Drupal 10 and that all those pages are displaying up-to-date information, including the launch date of Drupal CMS.

Keep up the good work!

@ressa Thank you for raising the issue about Slack. I agree with you all the way. And the points you raised are the reason I never install Slack on any of my computers or devices.

Forum links should direct to a real forum.

@fkelly12054@gmail.com I agree. As soon as the forum was removed from Drupal home page a long time ago, I stopped going over there to answer questions.

The home page needs to display that there is a live community and exposing a forum block would display that.

But at minimum a link to the forum is needed.

I love very much the new design and all the displayed information. But the design is static and will always display the same information. Not sure newbies or regular users will revisit the home page regularly.

I like very much the new home page.

But, is there work to personalize to some extend the home page for a logged in user?

More work is required to support the activation of the Navigation Top Bar module correctly.

Currently, the Navigation Top Bar is visible only on small breakpoints.

Leaving as “Needs review” for now.

The “Expand sidebar” text is now dealt with in ✨ Replace the mobile horizontal sidebar with a corner widget Active , in which the actual display of the label is hidden.

The “Expand sidebar” banner styling is now dealt with in ✨ Replace the mobile horizontal sidebar with a corner widget Active .

xmacinfo → created an issue.

xmacinfo → created an issue.

Why do you require Devel in the Composer file require-dev section? In your code, your code already checks if devel is installed.

if ($this->moduleHandler->moduleExists('devel')) {

Even if it is in require-dev, I try not to impose dependencies, even the most popular ones.

Text changed to match the subsystem maintainer review.

Thank you!

Thank you!

xmacinfo → created an issue.

Thanks for the quick resposte, daffie.

Let's plan to implement this:

Database support for JSON
Available
Drupal requires databases that support JSON storage.

or

Database support for JSON
Not available
Drupal requires databases that support JSON storage.

That last one, hopefully, mostly not visible ot users.

@debrup Please check the Devel Github issue queue to see if this is already reported. If not, open a new ticket over there:

https://gitlab.com/drupalspoons/devel/-/issues

It looks like that Drupal can be installed without JSON supportL

if (!Database::getConnection()->hasJson()) {
  $requirements['database_support_json']['value'] = t('Not available');
  $requirements['database_support_json']['severity'] = REQUIREMENT_ERROR;
}

So the status report will display either:

Database support for JSON
Available
Is required in Drupal 10.0.

Note that I did not try to install Drupal on top of a database without JSON support. But by ready the code, installing Drupal without JSON support is possible, unless the installer halts early on, displaying a missing requirement error message.

or

Database support for JSON
Not available
Is required in Drupal 10.0.

Based on that information, we should simplify to:

Database support for JSON
Available

or

Database support for JSON
Not available

Looking again at at the status page, we have:

Database support for JSON
Available
Is required in Drupal 10.0.

To be consistent with other requirements status we can simplify to:

Database support for JSON
Available

However, since this JSON support is “Required” for Drupal 10 and 11, we might prefer:

Database support for JSON
Enabled

As for the correct solution to implement (change of text) or the removal of the confirmation status, I would defer to the database product manager.

Who is the database product manager?

On the MySQL side, Drupal 11 requires “MySQL/Percona 8.0”.

https://www.drupal.org/docs/getting-started/system-requirements/database... →

If MySQL 8.x supports JSON by default, I tend to agree with longwage.

Devel is also working on exposing their menu in the Navigation. See the Github issue linked above.

Before going further, we may need to check with them the best course of action.

I did not try your code yet, though.

Devel integration to Navigation ticket:

https://gitlab.com/drupalspoons/devel/-/issues/530#note_2206580745

Actually, Devel itself should expose it's menu directly in the new Navigation menu. But I would find it more convenient to see the Devel menu injected directly in the Tools (managed by Navigation Extra Tools) menu.

I would expect to see the user image in the expanded panel, at the top (above or below the user name), inside or near the div toolbar-popover__header.

As for the main navigation, I consider that consistency is better. So in short, for the main navigation menu footer, I prefer the statu quo; using the current icon/text.

xmacinfo → created an issue.

Fixed the “white space appears above the Navigation footer and the main Navigation links” part.

Leaving this issue as “Needs review” for the “Notice the white “Expand sidebar” banner at the top” part. Not sure yet if xNavigation needs to style the white “Expand sidebar” banner or use a colour defined in the colour schemes.

xmacinfo → created an issue. See original summary → .

xmacinfo → created an issue.

“Expand toolbar” is too generic, and not clearly linked to the new Navigation toolbar. It would be best to write “Display admin menu”. That way, no need to add a logo.

I prefer “Display admin menu”, but “Expand admin menu” also work.

xmacinfo → created an issue.

Added additional colour schemes, including one called Core.

xmacinfo → created an issue.

xmacinfo → created an issue.

An unrelated test fails. Leaving the status as Needs review for now.

/core/modules/system/tests/src/Functional/System/StatusTest.php fails.

There's also seckit which also can set the CSP headers.

Can we set the CSP heasers on both public and private served files? Is Seckit able to add CSP headers on files?

@nmangold Thanks for all the clarifications. I try to summarize the issue with assumptions and what needs to be done.

So:

• The node $links are already styled (but not shown to respect design decision).
• There is no need to add a theme settings.
• We currently need to create a sub-theme and we want to avoid this.
• Existing config can be used.
• Make Olivero hide (not exclude) the node Links field by default in the content type teaser
• Support already installed sites with a hook post update to hide by default the node links field

Once fixed the user stories would be:

"As a product manager for Olivero, I want the node Links field to be hidden by defautl."
"As a site builder, I want to set the node Links field to be visible via the content type teaser configuration."

I think the correct plan is:

1. Add a setting in Olivero with “Hide 'Read more' link in teasers.”, which would be enabled by default.
2. Change the teaser template to respect the setting.
3. Style Olivero to support the display of $link when the setting is set to show links.

That way, user do not need to create a sub-theme based on Olivero.

I like the way the discussion is moving to. But the main question are:

Do we plan to implement the change in Olivero without the need to have a sub-theme?

Or, to display the links, we need to create a new sub-theme based on Olivero?

In short, a single theme (Oiivero) or two themes (Olivero and the sub-theme)?

sites will likely already have a template override

Having template overrides also mean working in another theme based on Olivero. This requires templating or hooks overrides knowledge.

Another option to expose this decision more clearly is to have a theme setting which ultimately drives the Link field display configuration, e.g. "Hide the node 'Read more' link in teasers.", which would be enabled by default.

I think this is the best solutions for Olivero users who do not need to create a sub-theme based on Olivero. With an option (on or off), a user does not need to know about templating or hooks.

However, if the settings is off or hidden by default, when switched on, will it be styled correctly? If switching it to display the the visual is not on par with the rest of Olivero, the user will be forced to create a sub-theme.

But, based on previous conversation, we might not see a styled version of the $links when a user set the setting to “Display the node 'Read more' link in teasers”.

The previous error may be due to having the contrib version of Navigation loaded on an old install of Navigation Extra Tools, which fixed the dependency in a never beta release.

xmacinfo → created an issue.

OK. It works out of the box. Thanks.

I see. I'll try to see if I can install it later.

I think that rebuilding the theme registry should be done in the install file in a hook_update; a one time rebuild at installation or when updating to a newer version.

xmacinfo → created an issue.

Logo reviews are appreciated.

Left this issue as “Needs work” to create the branch and commit.

Planned logo for this project.