Contrib.social

Fix issues reported by PHPCS

Open on Drupal.org →
Created on 5 July 2024, 5 months ago
Updated 22 July 2024, 4 months ago

Problem/Motivation

With the integration of GitLab CI from 📌 Add Gitlab CI to V2 of the module Active there is now a report for PHPCS issues at https://git.drupalcode.org/project/activecampaign/-/jobs/2043631

PHP_CodeSniffer version 3.10.1 (stable) by Squiz and PHPCSStandards
$ composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.19
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1
$ vendor/bin/phpcs --config-show installed_paths
Using config file: /builds/project/activecampaign/vendor/squizlabs/php_codesniffer/CodeSniffer.conf
installed_paths: ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard
$ vendor/bin/phpcs -i
The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard
$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source $_PHPCS_EXTRA
FILE: ...mpaign/src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 74 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 89 | ERROR | [x] The first parameter of a multi-line function declaration must
    |       |     be on the line after the opening bracket
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.FirstParamSpacing)
 90 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 91 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 92 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 93 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 93 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 93 | ERROR | [x] The closing parenthesis of a multi-line function declaration
    |       |     must be on a new line
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.CloseBracketLine)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...aign/src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------
 56 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 75 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 90 | ERROR | [x] The first parameter of a multi-line function declaration must
    |       |     be on the line after the opening bracket
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.FirstParamSpacing)
 91 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 92 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 93 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 94 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 94 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 94 | ERROR | [x] The closing parenthesis of a multi-line function declaration
    |       |     must be on a new line
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.CloseBracketLine)
 96 | ERROR | [x] Use null coalesce operator instead of ternary operator.
    |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...vecampaign/src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 61 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 82 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...vecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 40 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...aign/modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 48 | ERROR | [x] The first parameter of a multi-line function declaration must
    |       |     be on the line after the opening bracket
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.FirstParamSpacing)
 49 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 50 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.Indent)
 50 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 50 | ERROR | [x] The closing parenthesis of a multi-line function declaration
    |       |     must be on a new line
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.CloseBracketLine)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 202ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...tivecampaign_dashboard/src/Form/ActiveCampaignDashboard.php  5       0
...orm/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php  1       0
...Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php  2       0
.../Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php  10      0
...in/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php  9       0
--------------------------------------------------------------------------------
A TOTAL OF 27 ERRORS AND 0 WARNINGS WERE FOUND IN 15 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 27 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[x] Drupal.Functions.MultiLineFunctionDeclaration.Indent                   10
[x] Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma     10
[x] Drupal.Functions.MultiLineFunctionDeclaration.CloseBracketLine         3
[x] Drupal.Functions.MultiLineFunctionDeclaration.FirstParamSpacing        3
[x] SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.  1
--------------------------------------------------------------------------------
A TOTAL OF 27 SNIFF VIOLATIONS WERE FOUND IN 5 SOURCES
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SOURCES AUTOMATICALLY (27 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------

Steps to reproduce

https://git.drupalcode.org/project/activecampaign/-/jobs/2043631

Proposed resolution

Fix reported issues

Remaining tasks

Create MR
Review MR

📌 Task
Status

RTBC

Version

2.0

Component

Code

Created by

🇧🇪Belgium dtfabio Ninove

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dtfabio
  • Assigned to dev16.addweb
  • Comment 5 months ago →
    🇮🇳India dev16.addweb
  • Merge request !17Resolve #3459297 "Fix issues reported" → (Open) created by Unnamed author
  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇮🇳India dev16.addweb

    Hello @dtfabio,

    I created an MR and fixed phpcs problems. Review, please.

  • Pipeline finished with Success
    5 months ago
    Total: 1076s
    #218552
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇧🇪Belgium dtfabio Ninove

    Hi Silvi,

    When I run the pipeline again on this merge request I still get issues https://git.drupalcode.org/issue/activecampaign-3459297/-/jobs/2059320 , would it be possible to resolve these too and make sure the PHPCS pipline is running green.

    PHP_CodeSniffer version 3.10.1 (stable) by Squiz and PHPCSStandards
$ composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.19
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1
$ vendor/bin/phpcs --config-show installed_paths
Using config file: /builds/issue/activecampaign-3459297/vendor/squizlabs/php_codesniffer/CodeSniffer.conf
installed_paths: ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard
$ vendor/bin/phpcs -i
The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard
$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source $_PHPCS_EXTRA
FILE: ...459297/src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 74 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 94 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9297/src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 56 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 75 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 95 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...gn-3459297/src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 61 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 82 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...vecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 40 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9297/modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 51 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 193ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...tivecampaign_dashboard/src/Form/ActiveCampaignDashboard.php  1       0
...orm/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php  1       0
...Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php  2       0
.../Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php  3       0
...in/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php  3       0
--------------------------------------------------------------------------------
A TOTAL OF 10 ERRORS AND 0 WARNINGS WERE FOUND IN 15 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 10 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
-----------------------------------------------------------------------------
    SOURCE                                                              COUNT
-----------------------------------------------------------------------------
[x] Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma  10
-----------------------------------------------------------------------------
A TOTAL OF 10 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (10 VIOLATIONS IN TOTAL)
-----------------------------------------------------------------------------
  • Comment 5 months ago →
    🇮🇳India dev16.addweb

    I think we need to update the fork. What do you think?

  • Comment 5 months ago →
    🇧🇪Belgium tim-diels Belgium 🇧🇪

    Not all phpcs were fixed in the MR. And the pipeline was not green. So all issues needs to be adressed to be able to continue any reviews. But the MR is not even mergeable. So indeed needs to update the fork (rebase).

  • Pipeline finished with Success
    4 months ago
    Total: 144s
    #230763
  • Pipeline finished with Success
    4 months ago
    Total: 131s
    #230783
  • Pipeline finished with Success
    4 months ago
    Total: 149s
    #230836
  • Pipeline finished with Success
    4 months ago
    Total: 146s
    #230843
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇳India dev16.addweb

    Hi,

    I have updated the issue fork repo and fixed the remaining PHPCS issues. The Cspell and Stylelint jobs have also passed. The only remaining error is in the PHPStan job, which is due to the Webform dependent module.

    All other jobs have passed. Please review it.
    Before --> https://git.drupalcode.org/issue/activecampaign-3459297/-/pipelines/230763
    After -->https://git.drupalcode.org/issue/activecampaign-3459297/-/pipelines/230843

  • Assigned to hetal.solanki
  • Comment 4 months ago →
    🇮🇳India hetal.solanki
  • Comment 4 months ago →
    🇮🇳India hetal.solanki

    @all

    I have reviewed Mr! 17. There are few changes remaining.
    Moving to the Needs Work.
    Thank you!!

    FILE: /var/www/html/d10/web/modules/contrib/activecampaign-3459297/modules/activecampaign_dashboard/activecampaign_dashboard.links.menu.yml
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 24 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/d10/web/modules/contrib/activecampaign-3459297/modules/activecampaign_dashboard/css/admin-menu.css
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/d10/web/modules/contrib/activecampaign-3459297/src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
 96 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------

Time: 649ms; Memory: 12MB
  • Issue was unassigned.
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇮🇳India hetal.solanki
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇳India dev16.addweb

    @hetalsolanki,
    Have you checked after applying MR !17?

    modules/custom/activecampaign$ curl https://git.drupalcode.org/project/activecampaign/-/merge_requests/17.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 11063    0 11063    0     0  20795      0 --:--:-- --:--:-- --:--:-- 20795
Checking patch .cspell-project-words.txt...
Checking patch modules/activecampaign_dashboard/activecampaign_dashboard.links.menu.yml...
Checking patch modules/activecampaign_dashboard/css/admin-menu.css...
Checking patch modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php...
Checking patch modules/activecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php...
Checking patch src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php...
Checking patch src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php...
Checking patch src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php...
Applied patch .cspell-project-words.txt cleanly.
Applied patch modules/activecampaign_dashboard/activecampaign_dashboard.links.menu.yml cleanly.
Applied patch modules/activecampaign_dashboard/css/admin-menu.css cleanly.
Applied patch modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php cleanly.
Applied patch modules/activecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php cleanly.

    MR !17 applied cleanly and also please ignore css file on phpcs testing, Because I have fixed stylelint issues and it has been passed.

    www-data@a57cb9704236:/app$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/activecampaign/
www-data@a57cb9704236:/app$
  • Comment 4 months ago →
    🇮🇳India riddhi.addweb

    I tried MR17, and it applied cleanly, but it gave some CSS errors:- Let me know if these errors can be ignored or if we need to fix them. If the errors can be ignored then RTBC+1 and it can be moved to RTBC.

    FILE: /var/www/html/web/drupal10/web/modules/custom/activecampaign-3459297/modules/activecampaign_dashboard/css/admin-menu.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------
 15 | ERROR | [x] Selectors must be on a single line
 16 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
 16 | ERROR | [x] Selectors must be on a single line
 17 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
 17 | ERROR | [x] Selectors must be on a single line
 18 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
  • Status changed to RTBC 4 months ago
  • Comment 4 months ago →
    🇮🇳India riddhi.addweb
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024