- First commit to issue fork.
- Merge request !37Issue #3224734 by RoSk0: SMTPMailSystem::mail throws exception "Invalid... β (Open) created by ericgsmith
- last update
2 months ago 27 pass - π³πΏNew Zealand ericgsmith
Moved patch from #12 to MR.
While patch applies cleanly to 8.x-1.3 and all tests on the MR passed, manually testing found a error as 8.x-1.3 introduced additional code that expected logger to be a factory instead of the logger object.
Rather than update the code in debug method I have reverted the change to the constructor logic. I think it could be considered outside the scope of this issue and in recent times keeping the factory as the dependency is preferred.
- Status changed to Needs work
about 1 month ago 6:08pm 26 July 2024 - πΊπΈUnited States japerry KVUO
Made comments on the MR -- there are BC issues and I think we can use reflection instead of needing another public method.
- Status changed to Needs review
about 1 month ago 10:13pm 1 August 2024 - π³πΏNew Zealand ericgsmith
Thanks for the review Jakob - I believe I have implemented all the changes requested.