Fix: Warning: foreach() argument must be of type array|object, null given in menu_link_attributes_menu_link_content_form_entity_builder()

Here is the attached patch with the fix

With the given patch from #2, there's the risk of running into an error:

TypeError: array_merge(): Argument #2 must be of type array, null given in array_merge() (line 191

This seems to happen, when the user does not have the 'use menu link attributes' permission set

I've updated the patch to ensure an empty array, if the value is not set

Based on the patch in #6 it looks like this is actually a duplicate of https://www.drupal.org/project/menu_link_attributes/issues/3331630 🐛 Compatibility with other modules, options being overwritten. Fixed , which is already RTBC. Can we close this one?

🐛 Compatibility with other modules, options being overwritten. Fixed has already been fixed. Closing this as duplicate.

Sadly the other mentioned issue did not resolve this specific error - variables passed to NestedArray::MergeDeep() can still be NULL, which causes a warning. Reworked the previous patch to also check the second variable passed. If someone still has this error in ^1.5.0, you can check this patch.

Hi Anybody,

I am also still experiencing the same problem that the code gives a warning if the arrays passed to NestedArray::mergeDeep() contain a NULL value.

In my case, this happened logged in as webmaster, given the webmaster had no permissions to add attributes to the menu link item.

I have included alexrayu's code in an MR with one more check in case the user has no attribute add permissions, given that at this place a NULL was still passed to the mergeDeep function later in the code.

Behaviour without patch:

After adding the patch:

Would it be possible to review the change, so that a solution to this problem can be included in a future release?

Greetings,

Fabio

Thank you, yes, let's fix that.

Fixed in dev!

anybody → closed merge request !12

Automatically closed - issue fixed for 2 weeks with no activity.