Compatibility with other modules, options being overwritten.

I had the same issue while using this core patch #2924653: Allow preferred language selection for link field → , the proposed fix is good and work as expected.

The tests also passed with the right PHP version.

Reviewed and tested the patch, works well for me as well.

LGTM, RTBC++

Committing the changes for helping the maintainer.

Automatically closed - issue fixed for 2 weeks with no activity.

@jcnventura could you please tag a new release containing this fix? We just lost a lot of time to find out this was already fixed in dev...

Thanks!!

Can we PLEASE have a release for this? Just wasted a bunch of time running into this very same issue....
🐛 Menu Link attributes overrides menu link options provided by other modules Closed: duplicate .

I created a follow-up as I think it needs array_merge_recursive to deep merge the array or use one of these: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...

📌 Need to deep merge options for compatibility with other modules? Active

Still it makes sense to release this now, as it fixes an important incompatibility and improves the situation.

The implementation here still doesn't allow all contrib modules to provide their options, we created a follow-up issue for correctly merging the options using NestedArray::mergeDeep() here:
📌 Need to deep merge options for compatibility with other modules? Active