Looks legit! Going forward with this!
andrei.vesterli → made their first commit to this issue’s fork.
Going with this one too!
Closing this one as dublicate to this one https://www.drupal.org/project/commerce_timeslots/issues/3421582 🐛 Uncaught ReferenceError: Modernizr is not defined at timeslots.js Active
Heh....I am here for some support ;). I wrote this module a while ago...Don't have much time to support/maintain it but if it may help with your project, good luck man! You've done a lot already!
Yeah, I will push a new release to stabilize things around.
Hey @generalredneck, left a few comments, the rest is just perfect! Can you please address those so i can merge the MR and move forward?
p.s. i want to prepare a new release that will include these last merged MRs into the dev branch.
Yeah, you're right. This one gets easy as there are no major changes into the commerce core towards this module.
Also, it's a bit old, and I didn't touch it for a while. So, again, huge kudos to you, man, for helping me with that!
andrei.vesterli → made their first commit to this issue’s fork.
Again, very legit! Merging this too!
andrei.vesterli → made their first commit to this issue’s fork.
Looks legit! Merging it! Thx for your support!
andrei.vesterli → made their first commit to this issue’s fork.
Closing this one. Will fix it here https://www.drupal.org/project/commerce_merchant_warrior/issues/3523529 📌 Prepare the first stable release Active
andrei.vesterli → created an issue.
Hey @orkut murat yılmaz
Very good catch! Thx for your input! Merging it! will prepare a new release tag later on.
andrei.vesterli → made their first commit to this issue’s fork.
Pushed a new commit with the D11 support + phpcs fixing. It's a bit more to do for phpcs but will adjust that into a new issue.
https://git.drupalcode.org/project/smssystem/-/commit/ee4a882ab4c7d9aba1...
Moving to fixed this one.
Here is a working patch for assing the customer association with the anonymous user payment intents.
Pushed a new release 1.0.5 with D11 support.
andrei.vesterli → changed the visibility of the branch 3515789-add_d11_support to active.
andrei.vesterli → changed the visibility of the branch 3515789-add_d11_support to hidden.
andrei.vesterli → changed the visibility of the branch 3515789-add_d11_support to active.
andrei.vesterli → changed the visibility of the branch 3515789-add_d11_support to hidden.
Hi @jastraat
I will add this in the coming days. I will need to check it better for D11.
BR,
Andrei
Hey @shabana.navas
This looks like a working solution and is legitimate to me. I will prepare a new release later on. However, I will need to merge this patch with the dev branch.
Regards,
Andrei
Hey @sunilpawar
Can you add credits for me and @swickham?
Thx
Hey @sunilpawar
Sure thing. Here is the MR
This module does not support the Gin theme and should not. I think the issue should be posted there.
Hi there
Thx for your support. I will push a new release soon!
andrei.vesterli → made their first commit to this issue’s fork.
andrei.vesterli → created an issue.
Here is the JSONAPI example response with the view operation enabled
andrei.vesterli → created an issue.
nick.murza → credited andrei.vesterli → .
Good job guys!
andrei.vesterli → created an issue.
Additional patch update
andrei.vesterli → created an issue.
Hey @nick.murza
Looks like a workable solution. Can you please prepare an MR for that?
Hey @japerry
Thx for a quick response. Nope, I don't intend to use dev version. Also, I tested with the dev version before I posted this issue, and the same. Here you can see my working patch. I will just use it before the real issue will be fixed.
andrei.vesterli → created an issue.
Good job!
Also, this is the request response:
and here is the input type that seems to be hidden
: and no idea how the server treated it, as a file
type or something else...
Hi all
I've tested how this works and it looks like I can upload as many files as I want
Here are 25 only, but I've tried with 50 and could easily upload all the files.
Also, why do we need to share that info text if there are no such real limits? I mean, this is a Drupal "batch" and you can upload 10000000 files without issues.
Regards,
Andrei
Hey @the_g_bomb
It looks like there is no such command in https://docs.alphanodes.com/drush/drush10.html 10.x version for drush. It's better to have "devel" way drush commands. I am not sure when I'll find some time to do that but not now.
Thx for your ideas and findings.
Best,
Andy
Hi guys
Thx for this report. I didn't touch this module for a while. I didn't find big issues for D8 & D9. Of course, it has big issues for D10.
It requires 2 versions for normal support.
All I need is time.
andrei.vesterli → made their first commit to this issue’s fork.
Hi @Yasser Samman
Thx for your support for this module. I've pushed a few new changes and It looks to work just perfectly. I will push a new release asap.
andrei.vesterli → made their first commit to this issue’s fork.
Looks fine!
Hello @apemantus
First of all, thanks for your initiative and help with the project. Great job and effort.
I've left a few comments there. Can you please address them so, I've done a review and that seems to work perfectly!
Kind Regards,
Andrei