Contrib.social

Error if Avs Response is not set on the payment entity

Open on Drupal.org →
Created on 27 November 2024, 4 months ago

Problem/Motivation

We get the following error if the Avs details are not set on a Payment entity:

TypeError: Drupal\nofraud\Services\NoFraud::getAvsResponseLabel(): Return value must be of type string, null returned in Drupal\nofraud\Services\NoFraud->getAvsResponseLabel() (line 384 of /app/web/modules/contrib/nofraud/src/Services/NoFraud.php).

Backtrace	
#0 /app/web/modules/contrib/nofraud/src/Services/NoFraud.php(222): Drupal\nofraud\Services\NoFraud->getAvsResponseLabel()
#1 /app/web/modules/contrib/nofraud/src/Services/NoFraud.php(312): Drupal\nofraud\Services\NoFraud->prepareTransactionRequestPayload()
#2 /app/web/modules/contrib/nofraud/src/NoFraudOrderSubscriber.php(65): Drupal\nofraud\Services\NoFraud->sendTransaction()
#3 [internal function]: Drupal\nofraud\NoFraudOrderSubscriber->onPlace()

Not all payment gateways set the Avs details.

Steps to reproduce

- Add the Commerce Braintree module
- Create a new payment gateways using the Braintree plugin
- Checkout using Paypal or Braintree credit card method
- Notice you get the error on checkout complete

Proposed resolution

Put in a check to see if the AVS details are set before making a call to `sendTransaction`.

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇮🇳India shabana.navas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024