- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
@gaurav-mathur and @klidifia When testing issues, please provide the steps you have done. If there is a UI element, you can include screenshots as well. See my RTBC check list for more details: https://www.kristen.org/content/my-drupal-issue-queue-rtbc-cheat-sheet
Note also, that this cannot be RTBCed unless the code has been reviewed. This does not appear to have been done in #4 or #5. It looks like only testing is done. Please only move to RTBC if all the steps are done (see the blog post).
I'm leaving off credit for @gaurav-mathur and @klidifia until they can acknowledge they have read the blog post above and will try to provide more complete comments in the future.
I took a quick look at the patch and it's simple and doesn't appear to have any issues. Seems like a nice UX fix. Assigning to myself to try to get this into the next release.
-
Kristen Pol β
committed 7edea82e on 3.0.x authored by
RoSk0 β
Issue #3327992 by RoSk0, Kristen Pol: Show how many files a user can...
-
Kristen Pol β
committed 7edea82e on 3.0.x authored by
RoSk0 β
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 11:21pm 10 April 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Reviewed the code and it seems fine. I see
ini_get
used in core code and didn't see a helper method for this variable.This will get into the next release. Marking fixed.
- π³πΏNew Zealand klidifia Christchurch
Thank you. Acknowledged. Will use your exemplary "Reviewed the code and it seems fine. I see ini_get used in core code and didn't see a helper method for this variable." as a benchmark going forward.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
@klidifia Thanks for acknowledging... adding credit :)
Automatically closed - issue fixed for 2 weeks with no activity.