Show how many files a user can upload at once

Created on 19 December 2022, over 2 years ago
Updated 1 July 2024, 9 months ago

Problem/Motivation

If the user will try to upload more files than configured in PHP max_file_uploads files exceeding the limit will be silently ignored , leaving the user wondering what happen.

Proposed resolution

Extend help text for upload field, showing the current system limit.

Remaining tasks

  • Patch - done
  • Review
  • Commit

User interface changes

Additional information on the bulk upload form.

API changes

None.

Data model changes

None.

✨ Feature request
Status

Fixed

Version

3.0

Component

User interface

Created by

πŸ‡³πŸ‡ΏNew Zealand RoSk0 Wellington

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    @gaurav-mathur and @klidifia When testing issues, please provide the steps you have done. If there is a UI element, you can include screenshots as well. See my RTBC check list for more details: https://www.kristen.org/content/my-drupal-issue-queue-rtbc-cheat-sheet

    Note also, that this cannot be RTBCed unless the code has been reviewed. This does not appear to have been done in #4 or #5. It looks like only testing is done. Please only move to RTBC if all the steps are done (see the blog post).

    I'm leaving off credit for @gaurav-mathur and @klidifia until they can acknowledge they have read the blog post above and will try to provide more complete comments in the future.

    I took a quick look at the patch and it's simple and doesn't appear to have any issues. Seems like a nice UX fix. Assigning to myself to try to get this into the next release.

  • Issue was unassigned.
  • Status changed to Fixed almost 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Reviewed the code and it seems fine. I see ini_get used in core code and didn't see a helper method for this variable.

    This will get into the next release. Marking fixed.

  • πŸ‡³πŸ‡ΏNew Zealand klidifia

    Thank you. Acknowledged. Will use your exemplary "Reviewed the code and it seems fine. I see ini_get used in core code and didn't see a helper method for this variable." as a benchmark going forward.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    @klidifia Thanks for acknowledging... adding credit :)

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 9 months ago
  • πŸ‡²πŸ‡©Moldova andrei.vesterli Chisinau

    Hi all

    I've tested how this works and it looks like I can upload as many files as I want

    Here are 25 only, but I've tried with 50 and could easily upload all the files.

    Also, why do we need to share that info text if there are no such real limits? I mean, this is a Drupal "batch" and you can upload 10000000 files without issues.

    Regards,
    Andrei

  • πŸ‡²πŸ‡©Moldova andrei.vesterli Chisinau

    Also, this is the request response:

    and here is the input type that seems to be hidden: and no idea how the server treated it, as a file type or something else...

Production build 0.71.5 2024