billing profile info is never saved in stripe

I am facing the same issue where we need the billing profile information to be recorded in Stripe for reference especially the customer name.

I see the card name is recorded in Stripe but sometimes people use a company card and we really need the name on the order.

Thank you for looking into this.

Noticing this as well. Payment profiles are critical as address verification plays a major role in chargeback disputes.

It's very strange that the profile types are coded to 'billing' when they are supposed to be 'customer'?

See below:

What's in MR is useless since everything we have in the code works fine.
But I can reproduce this issue using the "Guest Checkout->Continue as Guest" button (on the login step). So in this case the account will not be created and the code in the attachCustomerToStripePaymentMethod() method will not run (most of the code will simply be skipped because the account is not authorized).
Payment profile updates happen here:

      if ($is_reusable && $customer_id && $email) {
        $payment_method_data = [
          'email' => $email,
        ];
        $billing_profile = $payment_method->getBillingProfile();
        $formatted_address = $billing_profile ? $this->getFormattedAddress($billing_profile) : NULL;
        if (!empty($formatted_address)) {
          $payment_method_data = array_merge($payment_method_data, $formatted_address);
        }
        PaymentMethod::update($stripe_payment_method->id, ['billing_details' => $payment_method_data]);
      }

And also an update for the user account:

        if (empty($stripe_payment_method->customer)) {
          $customer_data = [
            'email' => $email,
            'name' => $owner->getDisplayName(),
            'description' => $this->t('Customer for :mail', [':mail' => $email]),
          ];
          if ($is_reusable) {
            $customer_data['payment_method'] = $stripe_payment_method->id;
          }
          $customer = Customer::create($customer_data);
          $customer_id = $customer->id;
        }

The biggest problem is that:

$customer_id = $this->getRemoteCustomerId($owner);

So, we have no connection between the Drupal account and the Stripe account.
Theoretically, we could create an account just in Stripe, and then if the customer comes back to the site (one day) and buys something, we would link it to the Drupal account. Otherwise, the account will only be created in Stripe.
What do you think about this?

Yeah you are 100% correct about my MR being useless. :) I noticed that after not using it and having some billing addresses come through.

After further examination, there is something more than than just checkout as guest, because we have multiple checkout as guest orders that do have names and billing addresses on the Stripe payment transactions and those customers DO NOT have stripe accounts created. So I think some more debugging is in order before we automatically create Stripe accounts for all transactions.

I think this might be reproduceable by completing the checkout process with with bad card info. The user goes back to the payment form to edit the payment and there is a stale payment method stored on the form that can't be used or edited, and needs to set new card information. I think the billing profile is getting skipped on the subsequent transaction. The only transactions that we have in stripe right now that don't have a name or billing addresses are the ones where there was an initial canceled/failed payment attempt.

Creating Stipe accounts for all emails could be a very useful feature, but it should be a setting in commerce_stripe settings as I don't know if it's best to do that by default. Maybe it's fine, but it could be addressed in a separate issue if that is not actually why the billing profile is being lost.

@tonytheferg Thanks for the good explanation.
> Also my issue is with the card element.
You need to switch to Stripe Payment Element as Card Element is no longer receiving updates (only backporting some fixes for Payment Element).
I opened MR with some initial work related to creating a Stripe account for anonymous users (but it still needs some work). But since we need to use the Customer::search() method, it requires the new API version 2020-08-27 (we are still using 2019-12-03), so the work cannot be done at this time.

tonytheferg → closed merge request !150

Why not support the simple card element?

Here is a working patch for assing the customer association with the anonymous user payment intents.