The changes have been tested locally for all payment gateways, and everything works great!
Committed!
The main question is where it should point, as I can't find instructions. But the key that was generated a long time ago still works.
All pipelines are green. I also tested all payment gateways locally and they work great with the latest changes.
We need to check what was fixed here https://www.drupal.org/project/commerce_authnet/issues/3443580 📌 Fix eslint errors Active
@TomTech
I found another issue that was committed here https://git.drupalcode.org/project/commerce_stripe/-/merge_requests/129/....
For both shippable and non-shippable orders, we need to clear the checkout data set during the regular checkout process.
For the shippable orders, the onShippingAddressChange() method will be called first, so we can clear the data there (this is not currently happening).
Or we can change the overall approach and clean up checkout data from one place. In the onClick() JS event (it is always called when a popup opens), we can make an Ajax call to a new URL where we will clear the checkout data set during the regular checkout process.
vmarchuk → made their first commit to this issue’s fork.
vmarchuk → made their first commit to this issue’s fork.
If the module is already installed (and the "whitelist_urls" configuration is not empty) and this patch is applied, the new "allowlist_urls" configuration will be empty. And this will break the functionality of the module.
We need hook_update() to move the values from the old "whitelist_urls" configuration to the new "allowlist_urls".
This also needs to be fixed:
label: 'allowlisted URLs'
There is only one test left to fix - AjaxAddCartConfirmationMessageTest.
Updated MR with the latest changes from commerce_email.
PHPStan issues still need to be fixed.
vmarchuk → made their first commit to this issue’s fork.
Closing this after 2 years of inactivity.
Move this back to the "Needs Review" as a lot of the code has been changed.
Already fixed!
Committed!
Committed!
vmarchuk → made their first commit to this issue’s fork.
vmarchuk → created an issue.
I partially fixed some tests and then realized that we might have to change the tests because the integration might be changed due to the code review. So this issue is currently on hold until the review is complete.
This issue should be fixed as part of this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
The dc-ajax-add-cart-popup.html.twig template can be overridden in the frontend theme and modified as needed.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Already fixed!
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Committed!
vmarchuk → created an issue.
Committed! Failed tests will be fixed in a separate issue.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
vmarchuk → created an issue.
vmarchuk → changed the visibility of the branch 3332554-D10-compatibility to hidden.
Committed! All failed pipelines will be fixed later.
vmarchuk → created an issue.
Committed!
@jsacksick Added some fixes, but not all, as per your comment. Please check my comment regarding anonymous checkout. I also need to check if the applyRate() method can be used.
Committed!
vmarchuk → created an issue.
vmarchuk → created an issue.
vmarchuk → created an issue.
@rszrama
It seems like the price of the product variation should be higher than $50, and in that case, it works well. And I can't find any information about this in the documentation. Only the following information was found in the Affirm modal:
vmarchuk → created an issue.
vmarchuk → created an issue.
Committed!
vmarchuk → created an issue.
Would it be possible to share a screenshot of your Drupal Stripe payment gateway settings? (admin/commerce/config/payment-gateways/manage/stripe_payment_element)
See the attached screenshot.
vmarchuk → made their first commit to this issue’s fork.
vmarchuk → created an issue.