@anybody @grevil
Do you mind tagging the release?
The only issue on our end is
this
✨
Stripe Express Checkout Element Integration
Active
- we need to clear the checkout data set during regular checkout when the pop-up opens. After that, we will be ready for release.
Is there anything else that needs to be fixed before release? We may have missed some comments here.
We're closing this issue as we can no longer reproduce it.
@tkiehne I think it's something else. We're working on integrating https://developer.authorize.net/api/reference/features/accept-hosted.html.
I've just double-tested it and it works as expected. A new "Ajax add to cart" form mode will be added for the order item type, and there you will be able to configure the formatter for the "Purchased entity".
If you see that the "Purchased entity" is using the autocomplete formatter, it means that the form mode does not exist for the order item type.
The dc_ajax_add_cart_popup theme can be overridden in your frontend theme.
Blocks were used for Drupal 7, but for Drupal 9-11, the "Ajax add to cart form" field formatter is used.
An issue has been created to update the documentation
https://www.drupal.org/project/dc_ajax_add_cart/issues/3555928
📌
Update the module documentation page and readme.md file
Active
I can't reproduce this problem anymore and I don't think we need an update button for every order item (this is a pretty rare case).
The only problem I see is that when we click the "Update" or "Delete" button, 2 Ajax requests are sent.
I don't think that's a problem at all. The message disappears because there is nothing to update: the quantity was not changed and the order was not updated. The message appears only when the order has been saved, see commerce/modules/cart/src/Plugin/views/field/EditQuantity::viewsFormSubmit().
The changes have been tested locally for all payment gateways, and everything works great!
Committed!
The main question is where it should point, as I can't find instructions. But the key that was generated a long time ago still works.
All pipelines are green. I also tested all payment gateways locally and they work great with the latest changes.
We need to check what was fixed here https://www.drupal.org/project/commerce_authnet/issues/3443580 📌 Fix eslint errors Active
@TomTech
I found another issue that was committed here https://git.drupalcode.org/project/commerce_stripe/-/merge_requests/129/....
For both shippable and non-shippable orders, we need to clear the checkout data set during the regular checkout process.
For the shippable orders, the onShippingAddressChange() method will be called first, so we can clear the data there (this is not currently happening).
Or we can change the overall approach and clean up checkout data from one place. In the onClick() JS event (it is always called when a popup opens), we can make an Ajax call to a new URL where we will clear the checkout data set during the regular checkout process.
vmarchuk → made their first commit to this issue’s fork.
vmarchuk → made their first commit to this issue’s fork.
If the module is already installed (and the "whitelist_urls" configuration is not empty) and this patch is applied, the new "allowlist_urls" configuration will be empty. And this will break the functionality of the module.
We need hook_update() to move the values from the old "whitelist_urls" configuration to the new "allowlist_urls".
This also needs to be fixed:
label: 'allowlisted URLs'
There is only one test left to fix - AjaxAddCartConfirmationMessageTest.
Updated MR with the latest changes from commerce_email.
PHPStan issues still need to be fixed.
vmarchuk → made their first commit to this issue’s fork.
Closing this after 2 years of inactivity.
Move this back to the "Needs Review" as a lot of the code has been changed.
Already fixed!
Committed!
Committed!
vmarchuk → made their first commit to this issue’s fork.
vmarchuk → created an issue.
I partially fixed some tests and then realized that we might have to change the tests because the integration might be changed due to the code review. So this issue is currently on hold until the review is complete.
This issue should be fixed as part of this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
The dc-ajax-add-cart-popup.html.twig template can be overridden in the frontend theme and modified as needed.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Already fixed!
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Committed!
vmarchuk → created an issue.
Committed! Failed tests will be fixed in a separate issue.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
Fixed in this issue https://www.drupal.org/project/dc_ajax_add_cart/issues/3541983 📌 Drupal 10 and Commerce 2.4/3.x compatibility fixes Active and will be available in version 3.0.0.
vmarchuk → created an issue.
vmarchuk → changed the visibility of the branch 3332554-D10-compatibility to hidden.
Committed! All failed pipelines will be fixed later.
vmarchuk → created an issue.
Committed!
@jsacksick Added some fixes, but not all, as per your comment. Please check my comment regarding anonymous checkout. I also need to check if the applyRate() method can be used.