- Issue created by @marchuk.vitaliy
- πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
A new branch "3481620-add-use-of" has been opened with fixes for PHP 8 features, but I don't think it's finished yet. Need to spend time on additional fixes and testing.
- π³π±Netherlands megachriz
Thanks for your work so far! I see that you removed properties from AbandonedCartMail and AbandonedCarts. Was that intentional?
- π³π±Netherlands megachriz
I see that you removed properties from AbandonedCartMail and AbandonedCarts. Was that intentional?
Ah, I see now that the properties are not removed, but are defined in the constructor instead:
public function __construct( protected Connection $connection, ConfigFactoryInterface $config_factory, QueueFactory $queue_factory, protected ModuleHandlerInterface $moduleHandler, protected TimeInterface $time, protected LoggerInterface $logger )
I'm not used to this pattern yet, but I agree it is the modern way forward.
- πΊπ¦Ukraine marchuk.vitaliy Rivne, UA
@megachriz
Yeah, this is "Constructor property promotion". Since this module is not that big, it makes sense to refactor everything possible to support all PHP 8 features.