Twig 3.0 issue

I also experienced this issue after upgrading to Drupal 10 and the above patch fixed it.

Given that this is a requirement for Drupal 10 and Drupal 9 is deprecated in a few weeks, I think this should be higher priority.

Actually, while the above patch avoids the error it doesn't replicate the old behaviour and introduces an issue where empty rows are displayed.

This version fixes that.

The patch in #3 works for me. The indentation inside the new if statement could be improved though.

Rerolled patch #3 and also addressed #4, please review it.

Thanks!

Reviewed the patch in #5 and tested on Drupal 10 installation.
Patch applies cleanly.

Checking patch templates/commerce-wishlist-user-form.html.twig...
Applied patch templates/commerce-wishlist-user-form.html.twig cleanly.

The Wishlist page works fine after applying the patch. Attached screenshots.
RTBC for me.

Can confirm #5 works on Drupal 10.1.

Strange this wasn't caught when marking the project D10 compatible considering this error even shows up in drupal-check and similar depreciation checking tools.

I suggest using filter,
{% for key, item in form.items if key|first != '#' %} => {% for key, item in form.items|filter((item, key) => key|first != '#') %}

Confirm #5 works on Drupal 10.2

----
have also manually tested #8 -- indeed, this will work too. I'm happy to mark Reviewed as is..

I can also confirm that the patch in comment #5 fixes the issue. What is suggested in comment #8 also works fine, but the solution in comment #5 is simpler to understand what is going on there.
+1 to RTBC

Committed, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.