🇺🇸United States @rhovland

Can confirm this fixes the issue in Drupal 10.3.9. While I wasn't seeing any performance impacts in most areas of my site the permissions page was completely broken and hit the server timeout whenever I tried to load it. Applying this MR as a patch restores the performance.

When I tried it it masked the entire menu item. Maybe I did it wrong? I'm not familiar with using mask to change svg color.

I just tested it again. This time using the standard profile. Enabled the media module, added the embed media button to the basic text format.

Created a new basic page. Clicked the add media button. Class media-library-widget-modal is missing.

rhovland → created an issue.

Was able to reuse the css variables for the icons and use a css filter to set their color to match the administration toolbar.

I added styles for the toolbar-tray. I did not add styles for the toolbar-bar since an admin cannot move menu items into that menu.

I was not able to use mask to set the color because that requires an actual dom element to function properly and modifying the structure of the toolbar isn't really a good idea if it's even possible.

rhovland → created an issue.

This was fixed in
📌 Unify 'Giftcard' and 'Giftcards' Terminology Across the Codebase Active

Providing a default value following the rules for the giftcard type seems pretty straight forward to me. If someone wants to enter a custom code they replace the default value in the text box.

If this was a setting, where would it be configured?

Normally I'd agree except in the vast majority of cases there will be only one gift card redeemed (if multiple is even enabled on the site). Additionally using a list will introduce usually undesirable visual changes that would then have to be themed away by site builders. While the module could provide some css to hide the list bullets, now we'd have to maintain CSS in the project where there was none before.

MR obviously needs to be changed if ✨ Gift card theme uses a table to display redeemed gift cards Active is merged.

Also I wrote this a really long time ago and I don't really understand what that code block in the inline form is doing so I still need to do some research to make sure it's correct.

rhovland → created an issue.

Closing this in favor of followup issues.

✨ Display the gift card balance on the redemption form Active
📌 Checkout pane language cleanup Active
✨ Gift card pane display only looks correct in the sidebar Active

rhovland → created an issue.

rhovland → created an issue.

Looks like this is a problem with my site's theme instead of this module. Closing.

Good to go. Tests pass and I have verified this fixes the problem.

While this probably isn't a super common situation to run into it's possible if someone installs commerce and commerce_giftcard and then runs drush pm:enable commerce commerce_giftcard without explicitly enabling any of the other commerce submodules.
This results in a broken database where you can't install commerce_store or remove commerce_giftcard to fix the situation.

Tested with the change in the MR. Now it installs correctly.

rhovland → created an issue.

rhovland → created an issue.

Tested MR. Everything works as expected.

Is there anything else that needs addressed in this issue or is this good to go.

Tested MR and can confirm it works. Seems ready to commit.

rhovland → created an issue.

rhovland → created an issue.

This module implements the bootstrap 5 built-in carousel, which looks like this https://getbootstrap.com/docs/5.3/components/carousel/#indicators
The styling of the indicators is different.

As for the image sizing problem can you show us what result you're getting?

For some reason the MR removed the required attribute for the code field on the giftcard entity. This has been reversed.
Also fixed a phpcs error.

So I started making a patch for this and stopped realizing that how this is implemented is probably entirely wrong. Most panes are composed of fieldsets with titles that are generated by drupal. Meanwhile this pane uses a theme template to display the pane title which will not match the other panes if the site theme is different than the default. For example, my patch uses an H5 tag, but the other one is a H3. Which one is correct? Most panes don't even have templates. They just create a form using the API.

I will spend some more time evaluating how other panes are built and build a new MR that addresses these concerns.

Did you file this issue against the wrong version of the module? 5.5.x is for the Bootstrap 5 module compatible with Drupal 11.

rhovland → created an issue.

In my testing the carousel image scales with the viewport. Are you referring to something else when you say responsive?

The default is to hide the description at the medium breakpoint and below. You need to change your settings for the carousel. Specifically the "hide captions" settings. And make sure "Add captions to your slides for add title and description over the image" is checked.

"position-relative" is necessary for the captions (absolute position) to align to the carousel item. Normally this is the element with "carousel-inner". But because this module allows for doing grid layouts inside the carousel the "col" elements are lacking this anchor for the captions which are absolute positioned.

Before this change any absolute positioned element within a carousel (eg the caption) would be positioned according the first parent element with a relative position property. That was the carousel container instead of the carousel item.

This bug fix essentially changed the parent element your absolutely positioned image aligns to. Why does your image have an absolute position?

After discussing this with the maintainer on Slack, they would like to migrate to using Webpack for this module and others as they did in another one of their modules
https://git.drupalcode.org/project/varbase_layout_builder/-/blob/10.1.x/...

Tests passing. Errors unrelated to MR.

rhovland → created an issue.

Comparing template changes between the 3.x and 4.x branch is as easy as cloning the module's git repo and then running the following in the cloned folder:
git diff 3.0.x 4.0.x -- templates/

So far only changes to content/media.html.twig

Further information is required. This is functioning normally on my test instance of commerce. Is it possible you have an issue with your site configuration/templates that is causing the email to disappear for anon customers?

Login method is outside the scope of commerce and as you discovered the email registration module provides an alternate login method that is compatible with commerce.

Closing this issue. If you feel this is in error please re-open.

This issue is a duplicate of ✨ Send Drupal Core welcome email to new registrations during checkout Needs work

When addressing spelling issues adding words to the dictionary should only happen for valid words.

For instance "fewfsfs" is part of an API key. This should not be added to the dictionary. Instead the the following should be appended to the line above the API key in the test
// cspell:disable-next-line

The address in the test "2630 Hegal Place" should be modified so it does not trip the spell checker.

The usage of "autofills" is incorrect. It should say "Chrome autofill incorrectly fills this field with address line 1" as that is clearer language.

The improvements in #5 were lost. #5 was already Drupal 10 compatible. #8 should not have been committed.

rhovland → created an issue.

rhovland → created an issue.

I'm on the Drupal slack under the same username. We use this module regularly, albeit a heavily modified branch of it that I maintain myself. The number of patches was getting to hard to manage. If you're in need of a co-maintainer I'd be happy to help. I was already in planning to apply for it after I finished up work on another module.

Create an API access credential at https://developer.ups.com/

1. Login to your UPS account
2. Click "My Apps"
3. Click "Add Apps"
4. I need API credentials because: I want to integrate UPS technology into my business
5. Choose an account to associate with these credentials
6. Click the checkbox to agree to the terms then click Next
7. Enter contact details and click Next
8. Enter the App name
9. Leave Callback URL empty
10. In the Add Products section find "Rating" and click the + button to add it.
11. Click Save

Enter credentials in shipping method

• Billing Account number -> Account number
• Client ID
• Client Secret

rhovland → created an issue. See original summary → .

4.x always supported Oauth2
✨ OAuth 2.0 support? (D10+) Fixed

rhovland → changed the visibility of the branch 11.x to hidden.

rhovland → changed the visibility of the branch 10.1.x to hidden.

rhovland → made their first commit to this issue’s fork.

Created a new branch for 3.0.x. Attempted to address the creation time issue.

rhovland → changed the visibility of the branch 3.0.x to hidden.

Test failure seems to be unrelated to this issue

Maintainers: Does this need a test?

I'm uncertain what is the correct way to address this issue at the moment.

The patch in #9 "works" but it introduces a bunch of specialty code to fix another module.

If #15 really works (I haven't tried it yet) then this can be discarded in favor of a note in the readme file telling users about the commerce_checkout_order_fields issue / patch and how to configure the display for this module to make them play nice together.

Even once autofill is implemented we still need to ensure the entered code is valid

This issue is for gift cards that have been assigned to a user account. Making them selectable during checkout.

When I wrote this issue there was no help text and seemingly no validation code implemented. If this has changed then this issue is obsolete.

I don't think adding the node constraint is advisable. Dart Sass already has a node version constraint in it. If someone tries to install it on an incompatible version they'll be told their node version is too old.

sass/package.json:
"engines":{"node":">=14.0.0"}

I switched over to Dart Sass.

The package node-sass-magic-importer was removed. It's only used function was to support glob syntax in @import. The places where globs were used all files were specified.

The package nodemon was removed. Dart Sass has built in support for watching and compiling changes. Changed watch script to make use of it.

Updated autoprefixer to the latest version. It doesn't seem to be used in the project though.

I recompiled the CSS. There were no significant changes besides some code style changes. Color hex values are compiled into rgb values. blank lines between selectors were removed. Map files were generated which will help with debugging the resulting CSS.

rhovland → created an issue.

rhovland → created an issue.

While the automated tests say this works with Drupal 11 when I installed the 1.x version in a fresh drupal 11 install things were broken. I did not put in the work to figure out why. I'd appreciate if someone can test it in a fresh install of Drupal 11.

Xs is still a valid breakpoint. What's not valid is specifying xs in class names.

For example
col-xs -> col
display-xs-block -> display-block

The Extra Small option still needs to exist, but the css code it sets is different than the rest and simply setting it to blank won't work either because then you end up with col- or display--block which is also invalid class names.

Ok the problem when there is an uneven number of items causing missing closing tags should be fixed now. This was actually a problem before introducing the row div it just didn't break the html enough to be noticeable before.

I also fixed the positioning of captions with the multi column layout.

Yeah there's something wrong with the structure in certain circumstances related to adding another level of divs. I'm seeing the wrong number of closing divs when there's two columns but three items.

Trying to make sense of what's going on and fixing it.

Fixed and tested.

While I was in there I noticed that the code to set row_classes was duplicated. The first instance of it will never be used if the if statement evaluates false. And it is set again inside the if statement.

rhovland → created an issue.

Configuration item added.

Needs an update hook written.

rhovland → created an issue.

rhovland → created an issue.

Fixed issue. I also updated the urls in the configuration form pointing to the bootstrap documentation to 5.x versions in a separate commit so you can drop that change if it is not desired.

rhovland → created an issue.