MR !88 solves the problem, but doesn't address the root cause. There are also numerous other issues with event listeners in this release.
Multiple identical document level event listeners are being added more than once, which may or may not effect performance, but in any case is bad practice. Even if we check for the menu being open before trying to close it, it still adds an event listener unnecessarily every time the menu is closed. It also adds event listeners multiple times for each menu link.
The above merge request should fix all of this.
fraserthompson → made their first commit to this issue’s fork.
fraserthompson → created an issue.
fraserthompson → created an issue.
fraserthompson → created an issue.
Actually, while the above patch avoids the error it doesn't replicate the old behaviour and introduces an issue where empty rows are displayed.
This version fixes that.
I was experiencing this issue after upgrading to Drupal 10 and PHP 8.2 and the above patch fixed it.
I also experienced this issue after upgrading to Drupal 10 and the above patch fixed it.
Given that this is a requirement for Drupal 10 and Drupal 9 is deprecated in a few weeks, I think this should be higher priority.
Also confirming that the dev branch works with Composer on Drupal 10 but the current stable release doesn't and throws an error.
This would be really useful for odd use cases, such as ours. We want to break the "one price field per currency" thing and have two USD fields which are used in different stores. Out of the box this isn't possible, but if we could plugin to the resolver we could do this simply without modifying this modules code.
Patch adds tokens so we can access translation source values on commerce products eg. `[commerce_product:source:title:value]`
fraserthompson → created an issue.
This would be a very useful feature and the patch looks good. Can it be merged?
fraserthompson → created an issue.
fraserthompson → created an issue.