Support storing credentials outside of configuration

Created on 25 January 2023, almost 2 years ago
Updated 15 March 2023, over 1 year ago

Problem/Motivation

Storing credentials in configuration is bad practice, but as far as I can tell commerce_paypal makes doing the right thing a bit tricky.

You can override the client_id and client_secret for a gateway in settings.php via $config['commerce_payment.commerce_payment_gateway.[your_gateway]']['configuration'], but since the UI doesn't know about overriden config values, this means you can't save the gateway config form because it will fail validation. So if you want to make changes to conditions or other settings you can't.

Proposed resolution

The best solution imo would be integrating with the key module, which would allow storing credentials in config as it is currently, or any of the other providers supported by plugins.

But making the config form aware of overriden configuration when saving would also solve this problem.

Feature request
Status

Active

Version

1.0

Component

PayPal / IPN

Created by

🇳🇿New Zealand fraserthompson Dunedin, New Zealand

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @fraserthompson
  • 🇩🇪Germany rgpublic Düsseldorf 🇩🇪 🇪🇺

    +1. Coming from the commerce_braintree module and was pretty disappointed that this doesn't work out-of-the-box here. Als makes it unnecessary difficult to automatically switch between development and live systems.

  • 🇩🇪Germany rgpublic Düsseldorf 🇩🇪 🇪🇺

    PS: It would already help if the credential fields were optional and could be left empty.

Production build 0.71.5 2024