- Issue created by @marchuk.vitaliy
- Merge request !20Issue #3461347: PHP 8.3 compatibility (bump lcobucci/jwt to ^5). → (Open) created by Unnamed author
- Status changed to Needs work
12 months ago 7:15am 15 July 2024 - 🇺🇦Ukraine marchuk.vitaliy Rivne, UA
Updated to
lcobucci/jwt:5.3.0
and tested locally (composer require 'lcobucci/jwt:5.3.0 as 4.3.0'
) and it works great. Thelcobucci/clock
library has been replaced bypsr/clock
.
Opened MR with the fixes.
There seems to be a problem running the tests:Problem 1 - lcobucci/jwt[5.0.0, ..., 5.4.x-dev] require ext-sodium * -> it is missing from your system. Install or enable PHP's sodium extension. - Root composer.json requires lcobucci/jwt ^5 -> satisfiable by lcobucci/jwt[5.0.0, ..., 5.4.x-dev]. To enable extensions, verify that they are enabled in your .ini files: - /usr/local/etc/php/php-cli.ini
So that should be fixed as well.
- First commit to issue fork.
- 🇺🇸United States rhovland Oregon
I'm very confused as this seems to suggest sodium is built into php now https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911135
But runningphp -m
sodium is not listed there. It is in Ubuntu PHP installations though.
Additionally it cannot be installed via PECL because it was abandoned since PHP 8.1
And it is not in the list of "provided but not enabled" PHP modulesI added a composer command to ignore the lack of that module in .gitlab-ci.yml
Tests seem to pass despite the module being missing?
- 🇺🇸United States rhovland Oregon
Ok finally everything is good to go.
The only test failures are project level that have issues to address them. Everything is green otherwise
📌 Fix eslint errors Active
📌 AcceptJsPaymentMethodTest fails due to invalid permission RTBC - Status changed to Needs review
10 months ago 11:40pm 30 August 2024 - 🇺🇸United States rhovland Oregon
Also note that apparently PHP 8.3 is required to run Drupal 11 so this module isn't actually Drupal 11 compatible until this is addressed.
- 🇺🇸United States rhovland Oregon
Apparently lcobucci/clock was updated to support PHP 8.3 and 8.4 which made this module compatible with Drupal 11.
I have double checked this on a fresh Drupal 11 project.
Still would be a good idea to upgrade to a newer version eventually.
- 🇮🇱Israel jsacksick
So this is no longer urgent right?
I see that tests are passing in 📌 Fix the test failures Active .