Consider using the commerce_cart[cart_expiration][number] setting

Created on 18 October 2024, 3 months ago

Problem/Motivation

  • We must consider the commerce_cart[cart_expiration][number] setting if set, i.e. history_limit must be less than commerce_cart[cart_expiration][number] otherwise all carts can be deleted before sending emails (don't forget about multiple order types?)
  • Additionally, we can delete an entry from the commerce_abandoned_carts table when a cart order is deleted (if the commerce_cart[cart_expiration][number] setting is set), as the cart information is then useless
πŸ“Œ Task
Status

Active

Version

2.1

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine marchuk.vitaliy Rivne, UA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @marchuk.vitaliy
  • πŸ‡³πŸ‡±Netherlands megachriz

    Good suggestions.

    About the first: history_limit must be lower than commerce_cart[cart_expiration][number], I think that it would be better to only warn the user that carts don't exist if they set history_limit to a higher value and not enforce that it must be lower than commerce_cart[cart_expiration][number].

    Second: good call to clean up records for no longer existing carts.

  • πŸ‡ΊπŸ‡¦Ukraine marchuk.vitaliy Rivne, UA

    @megachriz I agree with your suggestions.

Production build 0.71.5 2024