- Issue created by @tim-diels
- Assigned to dtfabio
- ๐ง๐ชBelgium dtfabio Ninove
Hi Tim,
I will check this out.
Greetings,
Fabio
- ๐ฎ๐ณIndia abhiyanshu_rawat
abhiyanshu โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia abhiyanshu_rawat
@tim-diels,
I have set the requirement in the module for the file. Please refer to the screenshot for more clarity. Thanks. - Status changed to Needs review
5 months ago 11:47am 28 June 2024 - ๐ง๐ชBelgium dtfabio Ninove
Hi abhiyanshu,
Thanks for doing the work that needed to be done, only I did already mention I was going to take this up.
In the future, it is best that you first check if someone else has not already specified that they are working on this before starting the ticket.
This also ensures no duplication of work, which is certainly important for larger tickets.
It is also best practice to transfer the ticket to "Needs review" after the work has been done, so other developers know it needs to be looked at.
I will test your solution.
Greetings,
Fabio
- Issue was unassigned.
- Status changed to RTBC
5 months ago 1:15pm 28 June 2024 - ๐ง๐ชBelgium dtfabio Ninove
Hi Tim,
I tried the code change and the site now asks to turn on file and I no longer get a fatal error.
Greetings,
Fabio
- ๐ฎ๐ณIndia abhiyanshu_rawat
@dtfabio, I waited for a while since the changes were not that big, so I went ahead and pushed them.
I will make sure to follow up on those things next time. Thank you for your valuable suggestions and the review. I appreciate your guidance! - ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
Hi abhiyanshu,
To be frankly, you waited for 26 minutes. So you don't give a chance for someone to set up the project and do the code changes ...
Thats not very friendly from your side. But as we're a friendly community and I was working together with Fabio to pick this up, I gave the advice to make you aware of it. I don't think your response is that professional so maybe something to work on next time you work on issues.Thank you both for the work and tests. I'll get this comitted.
- Status changed to Closed: outdated
4 months ago 5:46pm 2 August 2024 - ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
Seems we fixed the dependency in another issue ๐ Transform the architecture to use a dedicated streamwrapper Fixed so don't need this anymore.