Set requirement on file for main module

Created on 27 June 2024, 3 days ago
Updated 28 June 2024, 2 days ago

Problem/Motivation

When installing the module, then go to the field form. You'll get a fatal error when the file module is not installed.

Steps to reproduce

Install Drupal with minimal profile.
Install Cloudflare Stream
Have a content type and try adding a field
You should see the error

Proposed resolution

Set requirement in the module for file.

Remaining tasks

Create MR

User interface changes

-

API changes

-

Data model changes

-

๐Ÿ› Bug report
Status

RTBC

Version

3.0

Component

Code

Created by

๐Ÿ‡ง๐Ÿ‡ชBelgium tim-diels Belgium ๐Ÿ‡ง๐Ÿ‡ช

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tim-diels
  • Assigned to dtfabio
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium dtfabio Ninove

    Hi Tim,

    I will check this out.

    Greetings,

    Fabio

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia abhiyanshu_rawat

    abhiyanshu โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Success
    3 days ago
    Total: 148s
    #209606
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia abhiyanshu_rawat

    @tim-diels,
    I have set the requirement in the module for the file. Please refer to the screenshot for more clarity. Thanks.

  • Status changed to Needs review 2 days ago
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium dtfabio Ninove

    Hi abhiyanshu,

    Thanks for doing the work that needed to be done, only I did already mention I was going to take this up.

    In the future, it is best that you first check if someone else has not already specified that they are working on this before starting the ticket.

    This also ensures no duplication of work, which is certainly important for larger tickets.

    It is also best practice to transfer the ticket to "Needs review" after the work has been done, so other developers know it needs to be looked at.

    I will test your solution.

    Greetings,

    Fabio

  • Issue was unassigned.
  • Status changed to RTBC 2 days ago
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium dtfabio Ninove

    Hi Tim,

    I tried the code change and the site now asks to turn on file and I no longer get a fatal error.

    Greetings,

    Fabio

Production build 0.69.0 2024