hanan alasari β made their first commit to this issueβs fork.
Thank you, the issue seems to be fixed.
Tested, and looks fine, its doing the job without any bugs.
Thank you for implementing this new functionality.
I confirm that i could to be able to detach the editor window, and works fine with the automatic preview.
just want to mention this, in the window when i select automatic preview, any element can be edited automatically, except the title field, may
be we need to add the title block to the frontend editing settings?
Tested and reviewed. Looks good, thank you so much for the work that you have done here!
hanan alasari β made their first commit to this issueβs fork.
It has worked for me, thanks a lot.
- - I have first create fresh D10 and cloned the repo from https://www.drupal.org/project/media_pdf_thumbnail/git-instructions β
- - Installed the module with composer
- - Enable media module and add more than 20 files.
- - Enable media_pdf_thumbnail module
- - Change the media view display to use PDF thumbnails for media.
- - Run the cron /admin/config/system/cron or just run drush cron.
- - Go to the media view and configure field: Media: Thumbnail to use Media PDF Thumbnail Image Formatter settings and enable the checkbox
- to which page is use the thumbnail and this should be in this case just for file media type.
- - Test.. loading time looks good and i can see the thumbnails made from the first page of the PDF file.
If we just put this piece of code, in frontend_editing.module , this will also fix the problem.
foreach (Element::children($build) as $key) {
$cache_metadata = new CacheableMetadata();
foreach (Element::children($build[$key]) as $child) {
$cache_metadata = $cache_metadata->merge(CacheableMetadata::createFromRenderArray($build[$key][$child]));
}
$cache_metadata->applyTo($build[$key]);
}
what do you think, should i prepare a patch for that?
I think this issue i not to do with frontend_editing Contrib module, i think its related to Paragraphs and Paragraph_edit contrib modules, because they are both have issue with render caching of Paragraph-referenced entities and nested Paragraphs.
Tested successfully, i could add toc_js module integration to my site, and change/save the settings.
Due to the missing steps to test this issue properly and having difficulties to find a way to easily get the necessary containers connected, i have to put this issue again on needs to review.
The patch from Comment#4 tested successfully, i could apply it, and successfully enabled the module.