- Issue created by @thamas
- Assigned to hanan alasari
- π©πͺGermany hanan alasari kassel
I think this issue i not to do with frontend_editing Contrib module, i think its related to Paragraphs and Paragraph_edit contrib modules, because they are both have issue with render caching of Paragraph-referenced entities and nested Paragraphs.
- π©πͺGermany hanan alasari kassel
If we just put this piece of code, in frontend_editing.module , this will also fix the problem.
foreach (Element::children($build) as $key) { $cache_metadata = new CacheableMetadata(); foreach (Element::children($build[$key]) as $child) { $cache_metadata = $cache_metadata->merge(CacheableMetadata::createFromRenderArray($build[$key][$child])); } $cache_metadata->applyTo($build[$key]); }
what do you think, should i prepare a patch for that?
- π©πͺGermany a.dmitriiev
a.dmitriiev β made their first commit to this issueβs fork.
- @admitriiev opened merge request.
- Status changed to Needs review
over 1 year ago 7:42am 26 April 2023 - π©πͺGermany a.dmitriiev
The problem with nested paragraphs not reflecting the change that was done with frontend editing is due to wrong
root_parent
object that was passed to paragraph edit form, it should be not just the parent of current paragraph, but the root parent of the whole lineage of nested paragraphs, in the case of example, it is the node that has the paragraph reference field.Please check the MR.
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:16am 28 April 2023 -
a.dmitriiev β
committed cc2b1285 on 1.x
Issue #3336897: Frontend editing may not apply value changes of nested...
-
a.dmitriiev β
committed cc2b1285 on 1.x
- Status changed to Fixed
over 1 year ago 7:48am 28 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.