🇫🇷France @nicodh

MR 51 seems to work, only a deprecation notice: Deprecated function: Creation of dynamic property Drupal\entity_clone\EntityClone\Content\ContentEntityCloneBase::$uuid_map is deprecated in Drupal\entity_clone\EntityClone\Content\ContentEntityCloneBase->updateLayoutParagraphs() (line 171 of modules/contrib/entity_clone/src/EntityClone/Content/ContentEntityCloneBase.php).

It needs a property declaration of uuid_map

Addresses also #3473034 (standardize phone value).

Merge branch from #3452986 (https://git.drupalcode.org/project/webform/-/merge_requests/477/diffs?co...)

nicodh → changed the visibility of the branch 6.3.x to hidden.

nicodh → created an issue.

Seems to work! Thanks

Merged in 1.0.0-beta2.

nicodh → made their first commit to this issue’s fork.

I've got 3 warnings when saving without opening metatags:

Warning: Undefined array key "value" in Drupal\metatag_async_widget\Plugin\Field\FieldWidget\AsyncMetatagFirehose->massageFormValues() (line 227 of modules/contrib/metatag_async_widget/src/Plugin/Field/FieldWidget/AsyncMetatagFirehose.php).

Warning: Undefined array key 0 in Drupal\metatag_async_widget\Plugin\Field\FieldWidget\AsyncMetatagFirehose->massageFormValues() (line 227 of modules/contrib/metatag_async_widget/src/Plugin/Field/FieldWidget/AsyncMetatagFirehose.php).

Warning: Trying to access array offset on value of type null in Drupal\metatag_async_widget\Plugin\Field\FieldWidget\AsyncMetatagFirehose->massageFormValues() (line 227 of modules/contrib/metatag_async_widget/src/Plugin/Field/FieldWidget/AsyncMetatagFirehose.php).

Hi,
I've rerolled the patch in #21 with #31 suggestions

Hi!
Thanks, the merge request seems to fix this issue (commit 3e411123) on a staging project, I will try on other projects and let you know.

#9 works! Thanks

I have made some changes that seems to work for me: https://git.drupalcode.org/issue/json_ld_schema-3488126/-/commit/82e49d8...

nicodh → created an issue.

Also same error for me, as #36. I need 5.4.0 + patch from #26 to be able to run drush cache clear

Path in #17 works for me with Layout Paragraphs and select2 field in modal form

You need menu_manipulator.menu_tree_manipulators:filterTreeByCurrentLanguage (instead of filterByCurrentLanguage)

Works for me! Thanks!

Re-rolled with config schema mapping added.

Works for me (I had the issue described in #2980527: Domain-based language negotiation strips "destination" URL query argument, causing BigPipe error).

#12 works with Drupal 10.2.6

Tested with Drupal 10.2.6, it works well with pager inside modal and without views. I use pager render array like this :

[
        '#type' => 'pager',
        '#route_name' => '<current>',
]

It works! Thanks!

Hi

I've used a puppeteer rendering engine, with spatie/browsershot bridge. It works fine, but needs some host setup (to have nodejs available). But the render, with all CSS3 features, files links... it's amazing and easy to write compared to mpdf !
I could write documentation about that, I just need some time to clean code :-)

saschaeggi → credited rkcreation → .

My patch works with `composer require npm-asset/dropzone:^6@beta`: we needs 'dropzone/dist/dropzone-min.js' and 'dropzone/dist/dropzone.css'.

I also try with merge-plugin, merging plugin's composer.libraries.json, so installing enyo/dropzone (5.7.2).

* merge-plugin composer.libraries.json (enyo/dropzone 5.7.2) : OK
* repositories of root composer.json + enyo/dropzone 5.7.2 : OK
* npm-asset/dropzone:^6@beta : NOK
* npm-asset/dropzone:^5 (5.9.3) : OK

IMHO, I prefer npm-asset/* method, it seems more friendly for updates etc. See https://www.drupal.org/project/select2 → for example.

I will try to find some time to do a merge request.

I suggest to allow more options: I try to install using composer require npm-asset/dropzone, and library is not detected.
Attach a patch that fixes also js / css detection in library alter (not only in requirements check).

Thanks @mxr576 for this. Could you try this module with #7 patch to confirm that it works ?

It works for me! Thanks!

After testing on another project, I add test for DKIM domain on plugin's settings form.

Could someone review this code?
It concerns only DKIM signing, but could be useful and merged IMHO (more and more email providers block unsigned emails).

Hi,
I have the exact same issue (locked by antibot due to this js error on login page). This patch solved this.
For sites that have gin rc9 + antibot (+ js aggregation in production), this issue seems critical.
Thanks, you can merge this patch :-)

Rerolled with 2.0.5

Here is the patch with requested fixes.
Made on 2.0.4 only

Updated #101 with #102 comments + usage of metatag_data_decode / encode (to allow v1 / v2 compatibility).

Fix configuration variables + improve dkim keys informations

Hi,

I attach a patch with following changes :

• Introduces a new EmailAdjuster plugin: DkimSignerAdjuster, with configurable domain / selector and keys generation / DNS information
• Add a pre-send phase (needed to allow changes directly on fully-prepared symfony email, as described by symfony mailer's DkimSigner documentation)
• Introduces a new SigningHelper service (to factor methods like keys discovery/generation)

Sorry I forgot a bunch of code, new patch attached

rkcreation → created an issue.

I thought the property names were self-describing, but I rerolled the patch

Hi,

I rerolled the patch with @apaderno comments (services declarations, comments, method names).
I added a retro compat test for switchToOther service method (accepts uid or User entity).
I also unified route paths, and fix user toolbar link for switching back (with Gin theme - not tested in others - classes made the link hidden).
As it is this module is unusable IMHO (without entity operation and without switch back link).

Hi
I rerolled a patch, without token replacement, and handling default setting or query parameter to open pdf directly in browser.

rkcreation → created an issue.

rkcreation → created an issue.

Thanks!!

Hi,

Why did you remove src/Command/{Set,Get}ValueCommand.php ?
You should re-add these command files or also delete console.services.yml because it breaks Drupal Console.

Re-rolled for core 9.5.4.
I also add implementation of CachedDiscoveryInterface and RefinableCacheableDependencyInterface for MenuLinkManager, because I've experienced trouble with menu derivatives.
I think it might be MenuTreeStorage responsibility to propagate plugins' cache tags instead of this solution, but I've no really advised opinion on this and no time to explore this for now...

Fix issue with entities languages

Hi,

I experienced issues with cache / key-value keys.
I've added more verbose key-value store key, and also entity cache metadata to form.
I also fix a typo (mata tags).

I updated issue fork : https://git.drupalcode.org/issue/metatag-3057523, patch attached.

Dialog widget is a really cool feature indeed! Thanks @batkor

Hi,

With just some quick tests, I could make it work with a fancyTree extension (https://github.com/mar10/fancytree/wiki/ExtMulti)

• Use all bundle in libraries.yml : //cdn.jsdelivr.net/npm/jquery.fancytree@2.37.0/dist/jquery.fancytree-all.min.js
• In fancyTree options, allow keyboard and add settings :

  keyboard: true,
  multi: {
     mode: "sameParent"  // Restrict range selection behavior
  },
  extensions: ['multi'],
  

I can make a patch if you want, but I need help to test side effects (eg: why keyboard is set to false ?)

Thanks