Error: Argument #2 ($logger) must be of type Drupal\Core\Logger\LoggerChannel

Created on 2 February 2024, 10 months ago

Updated 8 July 2024, 5 months ago

Problem/Motivation

When the module is enabled in sites using a logger channel class different than Drupal\Core\Logger\LoggerChannel interface, the following error appears: Argument #2 ($logger) must be of type Drupal\Core\Logger\LoggerChannel

Logger channel service's class may change depending on the project it's installed. For example, if the contrib module monolog → is installed, the logger channel class changes to Drupal\monolog\Logger\LoggerInterfacesAdapter.

Steps to reproduce

- Install monolog.
- Install revision_cleanup.

Proposed resolution

In classes that requires logger channel service, require the LoggerChannelInterface instead of the specific LoggerChannel class.

🐛 Bug report

Status

RTBC

Version

1.0

Component

Code

Created by

🇪🇸Spain omarlopesino

Live updates comments and jobs are added and updated live.

Merge Requests

!2Error: Argument #2 ($logger) must be of type Drupal\Core\Logger\LoggerChannel
Open
🇪🇸Spain omarlopesino
updated 10 months ago

Comments & Activities

Issue created by @omarlopesino
Merge request !2Issue #3418889: Require LoggerChannelInterface instead of LoggerChannel → (Open) created by omarlopesino
Issue was unassigned.
Status changed to Needs review 10 months ago1:29pm 2 February 2024
Comment 10 months ago →
🇪🇸Spain omarlopesino
I've found this error after doing the fixes: Trying to access array offset on value of type null Cron.php:264

I've fixed it in the same MR because it would have conflicts with this issue, so it will be easier to review in this way.

Please review the MR, thanks!
Comment 5 months ago →
🇫🇷France nicodh
Works for me! Thanks!
Status changed to RTBC 5 months ago12:30pm 8 July 2024
Comment 5 months ago →
🇫🇷France nicodh

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024