- Issue created by @nicodh
- Status changed to Needs work
over 1 year ago 12:17pm 16 October 2023 - 🇧🇪Belgium weseze
Great idea.
I will have to make some time to test this.
The patch does not apply cleanly anymore against latest version. Is it possible to update?But looking over the code I already have some feedback.
1/
function entity_pdf_update_8004() { \Drupal::service('kernel')->rebuildContainer(); }
We should not do that. When adding (or changing) services, we should provide a post_update hook (empty one is OK if I remember correctly) to force Drupal into clearing cache on updates and deployments.
2/
Found a "dump($form);": Probably not needed? Or it needs some documentation?3/
We are introducing new settings, they should be defined in the config/schema/entity_pdf.schema.yml and defaults provided in the config/install/entity_pdf.settings.yml - 🇫🇷France nicodh
Here is the patch with requested fixes.
Made on 2.0.4 only - 🇧🇪Belgium weseze
The patch is working fine for me so I comitted it.
Do you have actual implementations for other engine that we could include?
Can you provide some documentation (for the readme and the project page) on how to create a new engine in a custom module?
If we have that I would feel comfortable making a new release.Or I could add you as co-maintainer to work on that?
- Status changed to Fixed
about 1 year ago 1:14pm 28 March 2024 - 🇫🇷France nicodh
Hi
I've used a puppeteer rendering engine, with spatie/browsershot bridge. It works fine, but needs some host setup (to have nodejs available). But the render, with all CSS3 features, files links... it's amazing and easy to write compared to mpdf !
I could write documentation about that, I just need some time to clean code :-) Automatically closed - issue fixed for 2 weeks with no activity.