- Issue created by @karlshea
- 🇺🇸United States karlshea Minneapolis 🇺🇸
Actually that isn't working either, I'm still not getting all of the properties of both coming through.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
Sort of figured it out, I think it's a race. If I set a breakpoint when that extend happens instance.options is totally empty. But when it's logged it's not empty so it's getting updated somewhere else as this is running.
- Merge request !8Fix extend modifying original object / Fix race condition on instance.options → (Merged) created by karlshea
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7 updated depslast update
5 months ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7 updated depslast update
5 months ago Waiting for branch to pass - Status changed to Needs review
5 months ago 6:15pm 25 June 2024 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7 updated depslast update
5 months ago Waiting for branch to pass - 🇮🇩Indonesia gausarts
Thank you.
Makes sense.
Minor CS:
https://git.drupalcode.org/project/splide/-/merge_requests/8/diffs#49716...Should be ended with
;.Oh, ok, you did it :)
- 🇺🇸United States karlshea Minneapolis 🇺🇸
Updated the description as well to reflect the actual issue
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7 updated depslast update
5 months ago Waiting for branch to pass -
gausarts →
committed 67983b46 on 2.0.x authored by
KarlShea →
Issue #3457091 by KarlShea: Race condition with instance.options in...
-
gausarts →
committed 67983b46 on 2.0.x authored by
KarlShea →
- Status changed to Fixed
5 months ago 3:08am 27 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.