Field storage target_type isn't getting set for plugin handling entity_reference fields

I wonder if returning target_type from getFieldDefinitionSettings() is a red herring? It looks like EntityReferenceItem from core is returning target_type from defaultStorageSettings(), maybe there needs to be a way of influencing that from within a computed field plugin?

Yes, looks like it, e.g. EntityReferenceItem::storageSettingsSummary.

$storage_definition is \Drupal\computed_field\Field\FieldStorageDefinition, which in its create() is initializing the defaults for the field type, which is "node" target_type. It doesn't seems like there's any way to alter that either.

Looks like ComputedFieldSettingsTrait is also conflating storage settings vs field settings as well which I don't think is hurting anything but I'm also not sure it's helping anything.

Drupal\computed_field\Field\FieldStorageDefinition might need a way of talking to the computed field plugin to get field storage settings? Or possibly getFieldStorageDefinition() in the ComputedField entity might do it? hook_entity_bundle_field_info_alter can't help because all you can do is set the settings on the storage definition which is just recreated each time it's accessed.

Looks like ComputedFieldSettingsTrait is also conflating storage settings vs field settings as well which I don't think is hurting anything but I'm also not sure it's helping anything.

Nope, it needs those settings there too.

Would definitely appreciate a look at this, seems to have fixed the entity_reference issue for me!

Looks like this interacts with the cardinality patch, some of the media formatters look at the field storage definition cardinality in their isApplicable method.

When that patch is in this will also need to be added to ComputedField::getFieldStorageDefinition():

// Set cardinality
$definition->setCardinality($plugin->getFieldCardinality());

Rebased MR!11 on top of the work in 🐛 Computed field should specify the cardinality of the field Fixed

I've committed 🐛 Computed field should specify the cardinality of the field Fixed so this needs rebasing again.

Rebased!

Made a few tweaks.

Could you check to see if it still fixes the problem for you?

Tested it locally and all works. Committed.

Thanks for reporting and working on this!

I'm going to file a follow-up for splitting the settings method into field settings & storage settings.

Thank you! It all appears to be working for me as well.

Automatically closed - issue fixed for 2 weeks with no activity.

If I am following along with this change, am I correct that this

public function getFieldDefinitionSettings(): array {
  return [
    'target_type' => 'media',
    'handler' => 'default:media',
    'handler_settings' => [
      'target_bundles' => [
        'image',
      ],
    ],
  ];
}

needs to be changed to

public function getStorageDefinitionSettings(): array {
  return [
    'target_type' => 'media',
  ];
}

public function getFieldDefinitionSettings(): array {
  return [
    'handler' => 'default:media',
    'handler_settings' => [
      'target_bundles' => [
        'image',
      ],
    ],
  ];
}

Am I understanding this change correctly?

@jonmcl yes, that's correct! My computed media field has exactly the same code.