SQL error after upgrading to 8.x-3.0-beta5

It appears to have something to do with a setting on MySQL, one that is called "sql_generate_invisible_primary_key". I read that if that is set to 0, then you should be good.
https://github.com/prisma/prisma/issues/20944
https://magento.stackexchange.com/questions/370387/mysql-error-mysql-doe...

I don't know how the issue should be fixed in an other way yet.

Some searching seems like it might work to do this inside a transaction? Untested MR created.

I tested the MR and I am still getting the same error.

Tested, it doesn't work. I don't think having sql_generate_invisible_primary_key enabled is compatible with what we have available to modify the schema in Drupal.

I tried creating a new table with the desired primary key, coping the data from the old table to the new one, and then renaming the new table to the old one. This works for me, but it might be a better idea to update the sql_generate_invisible_primary_key value.

Unfortunately the web user would need the SESSION_VARIABLES_ADMIN privilege to change the sql_generate_invisible_primary_key value.

I think approach looks good - added a comment to the MR as its using incorrect column definition.

Oh good idea! I tested this with sql_generate_invisible_primary_key enabled and it worked just fine.

+1 from me

This looks like a great solution, however calling a function that returns the current schema (in this case a call to feeds_schema()) is discouraged. If for whatever reason in the future the table "feeds_clean_list" would get removed, the update function would break. Update functions should never rely on the current implementation of hook_schema().

From https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...

Never assume that the database schema is the same when the update will run as it is when you wrote the update function. So, when updating a database table or field, put the schema information you want to update to directly into your function instead of calling your hook_schema() function to retrieve it (this is one case where the right thing to do is copy and paste the code).

Ahhh right, commit pushed with a static table definition.

I tested with the static table definition and it still works. Thanks for pointing that out.

+1 testing and works for me

Apologies @torfj for the bad advice - thank you @MegaChriz for picking that up and thank you @KarlShea for updating.

Thanks all! I merged the code!

Automatically closed - issue fixed for 2 weeks with no activity.