- 🇨🇦Canada Austin986
This patch #5 does not fix the issue yet. The problem is still existing.
How to re-produce
1. Add event1 6/8 ~ 6/9
2. Add event2 6/8 ~ 6/10
3. Add event3 6/10 ~ 6/11Now event3 is placed out of the table, in wrong place.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
Here is the Multiday Calendar Rendering Fix for Month view.
Week view is still broken, not have time to dig it why though. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
Complete fix for multiday events in Month / Week view
This patch fixes multiday events rendering issues for following cases:
- Month View
- Display multi-day item as a single column
- Display multi-day item as a multiple column row
- Week View
- Display multi-day item as a single column
- Display multi-day item as a multiple column row
- Month View
- last update
over 1 year ago Build Successful - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @austin986 opened merge request.
- last update
over 1 year ago Build Successful Could you add in the changes from #9 (merge request 12)? You ignored/skipped those.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
Final patch for complete fix for multiday event issues.
This patch has improvements so that all events are filled up not allowing empty spaces.
If you prefer to place each single day event in new row, please use 3255924-multiday-rendering-fix-v2.0.patch - last update
over 1 year ago Build Successful - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
This is patch of merged branch, meant to be the final patch.
@solideogloria I have merged 3255924-multiple-multiday-events branch into my branch.
Now my branch 3255924-multiday-rendering-fix has all fixes in this thread so far. It looks good to me, but I think an additional review would be helpful, as my use case probably doesn't cover everything.
- 🇨🇦Canada Austin986
@solideogloria no problem. Take as much time as needed please.
I tested several cases on my own project. (I was motivated to contribute cuz I really need to use this module with Multiday events, and seems no one is working on fix.)
So far so good in my current project scope, so I do not mind if it takes some time to review. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs work
about 1 year ago 4:39pm 25 October 2023 This will need work. In the original code, it has
$item->continuation = $item->getStartDate() < $this->currentDay; $item->continues = $days > $bucket_cnt; $item->is_multi_day = TRUE;These are all dynamic (undeclared) properties, which is deprecated.
Also, the code doesn't follow Drupal coding standards. Boolean values should be in all-caps:
FALSEorTRUEI also can't get all the warnings to go away and have the multi-day stuff still work...
So if someone wants to fix that is this issue or at 🐛 Creation of dynamic properties is deprecated Fixed , go for it. Probably do it here, because the patch here touches all the same code, and there will be merge conflicts if we try to fix it in two commits.
- 🇺🇸United States tregonia
Encountered issues with multiday events pushing the calendar days outside of the container. Applied #25 to Drupal (10.2.7) and the issue is resolved, with no errors found after a 5-minute review.
RTBC +1
I cannot speak to the changes needed; as mentioned in #26-#28.