- 🇨🇦Canada Austin986
This patch #5 does not fix the issue yet. The problem is still existing.
How to re-produce
1. Add event1 6/8 ~ 6/9
2. Add event2 6/8 ~ 6/10
3. Add event3 6/10 ~ 6/11Now event3 is placed out of the table, in wrong place.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
Here is the Multiday Calendar Rendering Fix for Month view.
Week view is still broken, not have time to dig it why though. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
Complete fix for multiday events in Month / Week view
This patch fixes multiday events rendering issues for following cases:
- Month View
- Display multi-day item as a single column
- Display multi-day item as a multiple column row
- Week View
- Display multi-day item as a single column
- Display multi-day item as a multiple column row
- Month View
- last update
over 1 year ago Build Successful - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago Build Successful Could you add in the changes from #9 (merge request 12)? You ignored/skipped those.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
Final patch for complete fix for multiday event issues.
This patch has improvements so that all events are filled up not allowing empty spaces.
If you prefer to place each single day event in new row, please use 3255924-multiday-rendering-fix-v2.0.patch - last update
over 1 year ago Build Successful - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - 🇨🇦Canada Austin986
This is patch of merged branch, meant to be the final patch.
@solideogloria I have merged 3255924-multiple-multiday-events branch into my branch.
Now my branch 3255924-multiday-rendering-fix has all fixes in this thread so far. It looks good to me, but I think an additional review would be helpful, as my use case probably doesn't cover everything.
- 🇨🇦Canada Austin986
@solideogloria no problem. Take as much time as needed please.
I tested several cases on my own project. (I was motivated to contribute cuz I really need to use this module with Multiday events, and seems no one is working on fix.)
So far so good in my current project scope, so I do not mind if it takes some time to review. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs work
about 1 year ago 4:39pm 25 October 2023 This will need work. In the original code, it has
$item->continuation = $item->getStartDate() < $this->currentDay; $item->continues = $days > $bucket_cnt; $item->is_multi_day = TRUE;These are all dynamic (undeclared) properties, which is deprecated.
Also, the code doesn't follow Drupal coding standards. Boolean values should be in all-caps:
FALSEorTRUEI also can't get all the warnings to go away and have the multi-day stuff still work...
So if someone wants to fix that is this issue or at 🐛 Creation of dynamic properties is deprecated Fixed , go for it. Probably do it here, because the patch here touches all the same code, and there will be merge conflicts if we try to fix it in two commits.
- 🇺🇸United States tregonia
Encountered issues with multiday events pushing the calendar days outside of the container. Applied #25 to Drupal (10.2.7) and the issue is resolved, with no errors found after a 5-minute review.
RTBC +1
I cannot speak to the changes needed; as mentioned in #26-#28.
- 🇺🇸United States rhankins
FYI - I have the same issue under 1.0.0-beta3 and the patch wouldn't apply.
solideogloria → changed the visibility of the branch 3255924-multiple-multiday-events to hidden.
solideogloria → changed the visibility of the branch 3255924-multiday-rendering-fix to hidden.
solideogloria → changed the visibility of the branch 3255924-multiday-rendering-fix to active.
I did my best to reroll, but I need some people to test the changes.
There were some large blocks of code that had merge conflicts, and I'm not certain of the correct outcome.
Someone else will have to work on this. I literally only use this module for one small thing, so I'm probably just going to give up if nobody else is going to help fix this.
- First commit to issue fork.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
I think some of the difficulty is from lots of merging instead of rebasing—I pushed up a MR with the 3255924-multiday-rendering-fix-merged-v1.1.patch applied and conflicts fixed, then a variable name fix.
It's working for me but I'm not sure I captured all of the fixes that were in the other two branches, I didn't know if some of those changes existed to fix issues or if they were from merge errors.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
I also think trying to fix coding issues here is an exercise in futility, it'll just lead to more rebase/merge issues down the road.
solideogloria → changed the visibility of the branch 3255924-multiday-rendering-fix to hidden.
solideogloria → changed the visibility of the branch 8.x-1.x to hidden.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
Pushed some CS fixes for code added in this MR.
I'm going to see if the changes work with my site. I have to adjust some custom TypeScript to work with the changes, I think, for me to test it.
I discovered the change in 🐛 Typo in the calendar-month-col twig template Active broke my TS. Once I fixed that, I can test the changes here.
The changes work great, as far as I can test. My test does not cover the entirety of the functionality changes, but I'm happy with what I use and see.
- 🇨🇦Canada Austin986
Hello,
It seems that drupal/calendar:1.0.0-beta2 already includes this fix.
Unfortunately, I wasn’t able to complete this work, so I want to thank everyone who helped merge parts of my contributions to address the multi-day issues. I really appreciate it!
I’m now wondering what might still be incomplete here. If there’s anything left to do, I’d be happy to contribute further.
Also, I was curious—since some of my work has been incorporated into drupal/calendar:1.0.0-beta2, is there a way to acknowledge or credit that contribution?
Lastly, I no longer see the error in drupal/calendar:1.0.0-beta2, so I’m wondering why this issue hasn’t been closed yet.
Any thoughts?
Look at the changes in the MR. It was broken in 1.0.0-beta3 for me, so the MR needs to be merged.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
It is definitely still broken in beta3 for me as well.