🇨🇦Canada @Austin986

Corrected namespace
from

use Drupal\migrate_tools\Commands\MigrateToolsCommands;

to

use Drupal\migrate_tools\Drush\MigrateToolsCommands;

Austin986 → created an issue.

Patch is here.

Now it added a wrapper div with class tablefield-table-wrapper

Austin986 → created an issue.

nicxvan → credited Austin986 → .

Add if statement to enable attaching file without path.

Austin986 → created an issue.

Austin986 → created an issue.

I found this issue is still active in D10.0.9
What is the point to keep previous email and user name in register form?

Any patch or fix for D10 ?

@Nick Hope

Also, for heads up, I am using this patch for D 10.0.9 in my project.

@Nick Hope

I am okay with remove "Type the remote image url above.", as I put it there simply because of easy css applying.
If to remove the description, need add some css fix, so that the button is placed in wanky position.

Added "Add New Remote Image" form into Media Modal.

@Nick Hope, I messed branch, so decided to create fresh one. Gonna close this.

Austin986 → created an issue.

Austin986 → created an issue.

Context variable is now added.

function yourmodule_online_base_content_remote_options__options_alter (&$variables, $context) {
// TO DO
}

Patch for 1.1.x

Patch created to provide a new hook

function yourmodule_online_base_content_remote_options__options_alter (&$variables) {
  // TO DO
}

Austin986 → created an issue.

phenaproxima → credited Austin986 → .

Made a fix to cover the issue for #64

- Logic updates
If image is not activated, this option wont work.

- UI Updates
Added description to explain this option is only applied if Image tool is activated.

@fsabbagh First of all this patch is not a perfect one, and I did not get some time to refine this patch.

You are seeing the error because you did not place [Insert Image] tool on toolbar.
The best scenario with this patch will be
- Use [Insert Image] only for remote images (by not allowing upload image)
- Use [Media] for insert images uploaded in the system already.

@gillesv I did some researches and found that these hooks are deprecated.
You need to use

hook_field_widget_single_element_WIDGET_TYPE_form_alter()

hook_field_widget_complete_WIDGET_TYPE_form_alter()

Here is API doc:
https://api.drupal.org/api/drupal/core%21modules%21field%21field.api.php/10

Set src-type by MediaSourceInterface->getPluginId(), to enable feature for custom media types.

Updated to avoid error when to use Remote Video option.

@dehacker
Thank you for your kind words, it 's my great pleasure to see someone really understands what I tried to cover.

@DamienMcKenna, @m.abdulqader
First of all, there is patch for Media resize (not sure if it works though) https://www.drupal.org/project/entity_embed/issues/2932871 ✨ Allow manual scaling of embedded image entities in CKEditor Needs review
And the purpose of this patch is to provide option to use <img> tag than <drupal-media> for Media Image in CKEditor, so that exactly same edit action can be applied to Media Image, too, for unified and easier UX.
I came to this solution per customer requests, and I do not see what makes you think this is not correct approach.

I am so fed up to explain every details one by one, even if it's so obvious that this additional option is actually provide better UX.

As long as Drupal is not a academic & scientific research project, I do not see right reason why we should reject progressive additions which provides better UX.

I no longer demand this function to be merged into Drupal. Good luck.

Fixed typo.

This patch does not work, and showing error because of file_create_url used.

Updates

• Made a fix
• Added new Item Format - File name, so that item simply can be printed with it's file name.

Austin986 → made their first commit to this issue’s fork.

This issue has been addressed and fixed on 6.2.x

Austin986 → created an issue.

I am facing same problem, and it's so frustrating nothing right solution can be found.

There is easy workaround to cover this issue.
You can find the patch her: CKEditor5, Provide a way to embed Media Image as primitive image in editor, to enable image edit functions ✨ CKEditor5, Provide a way to embed Media Image as primitive image in editor, to enable image edit functions Closed: duplicate

Currently Media Image is placed using <drupal-media> tag in editor, thus the image can not be edited like normal images.
Here is the patch available to cover this issue.

CKEditor5, Provide a way to embed Media Image as primitive image in editor, to enable image edit functions ✨ CKEditor5, Provide a way to embed Media Image as primitive image in editor, to enable image edit functions Closed: duplicate

Austin986 → created an issue.

@sean B Have you read full thread attached here?

First of all, this patch includes option to use <img> on <drupal-media> and default value is FALSE.

Never really ran into this before. - It does not mean that others wont run into this problem, I brought this from end users' perspective and requests.

The main benefit of view modes is that you can have responsive formatters - I do not see the point frankly. In order to make it fully responsive, need to edit TPL file any way (which will be handled by dev) and then question here is why dev needs to create 2 separate responsive CSS for both cases when it s same image posted in CKEditor.
I just simply wanna remind that there is another easier workaround, too.

CKEditor to a fixed size might be good for some images, but for responsive sites ... - Not really, when we build site using Drupal, we create responsive css for images in CKEditor, too, also there is modules to support responsive size option → for individual images (not sure if it works for CKEditor 5 though. )

I'm afraid we also can't skip the Drupal media tag since not every media item is an image. - I mentioned clearly in my comment, as well as it 's obvious by code itself, it only use <img> tag for Image types.

how about allowing to set a width / height attribute first? The attributes are ... - Rather edit sources to wrap with new div assigned specific width and height. Again, this patch is for those who want simply use <img> tag rather than <drupal-media> tag, to simplify and unify UX for Image handling in CKEditor.

It is so sad you do not see what I see.

@smustgrave Thank you for your kind direction, I did not see that there. Also I did not know that I should login again there, too. (did not notice I am a guest when checking MR)

@smustgrave Thank you for your notes.
I created branch from 10.1.x as you guided, but when I clicked Merge request, it processed as if I requested to merge into 9.5 dev.

Is there any configs I m missing?
What is the correct way to issue right merge request?
Just curious as I am new for this part, so any tips would be appreciated.

Patch Notes

Patch for Drupal 10.0.x

Patch for Drupal 10.0.x

Patch for Drupal 10.1.x

This patch enables additional option on Filter Settings of Embed Media in Text format configuration page: Use <img> tag for Media Image type , and the default value is FALSE (unchekced)

When you add a media, it becomes img only when

• you checked for Use <img> tag for Media Image type, and
• media you are adding is image type.

I do not see why it becomes regression when it has additional option available.

Also, by default, Media image is rendered with <img> tag in published view (unless you made custom tpl for specific display mode to use somewhat different tag), so I do not see why we could not allow them in <img> tag in CKEditor5.

I see the the benefits of display mode, which is useful if you want to provide various rendering way for image, that's why I made an option available.

Also I am gonna change the title of this issue because in deep, it does not make Media Image resizable.

I do not care if my patch would become a part of Core or not, but at least I want things to be considered for UX perspective.

@smustgrave

It's rather frustrating.
It sounds more like Media Library is only existing for it's own sake, not for better UX.

Is not Media Library purposed to provide better media management experience?
Why would users have to deal with folder-structure based file browser when they prefer manage images in Media Library?
I am afraid it could be one reason why people will prefer to use other CMS that UX is a kinda complicated and not unified.

People love to use Media Library because they can browse previously uploaded images in nice page view with search function.
That 's the reason people choose to use Insert Media over Insert Image.

It will be great there is the way to place media images using <img>, so that they can be configured same way with normal images.
I do not insist my solution is good enough (because it disables <drupal-media> for images for specific configuration), but this feature is really needed for better UX.

Maybe there can be 1 more button saying "Insert as Image" on Add Media dialog, so that user can choose how they like to use.

Please consider providing a way to place image into <img> via Media Library in future Drupal Core.

@smustgrave By enabling use <img> tag option, no longer <drupal-media> is not used for Media Image.
This usecase is for those who use media library in CKEditor5 only to select images, not much than that.
People mostly love to use Media Library to manage images in CKEditor5 because it has good organized view there, rather than using Media Embed itself.

@smustgrave So it sounds like I need to create D10 patch, too.
Do I need to create another branch for D10?
What is the standard process to make it mergeable for current Drupal Core dev?

@lauriii I am not a CKEditor developer, and it would take much time for me to dig into CKEditor core to enable resize function on custom tag. Regarding the fact that it renders <drupal-media> based on Drupal tpl (which can be fully customized), there will be not bullet-proof methodology to make code> element resizable safely. (I hope you understand the point what I am pointing, right?)

Current media image edit dialog has only Alt and Caption, I felt there is really not a good reason to keep <drupal-media> tag.
Apparently users do not care about it actually, they more care about functionality like resize.
It 's actually very natural question, "I imported image, but then why do I see <drupal-media> tag there?"

That's why I came up with this solution in pretty normalized way ( because now all images will have same edit workflow).

@Wim Leers Thank you for your kindness. I really hope this feature would be a part of Drupal core, so that for those lovers of Media Library can continue using it in CKEditor5. Cheers.

Guide

Once install patch, then visit text editor configuration page, enable `Use tag for Media Image type` option in Filter settings \ Embed media

Media image is not resizable directly in CKEditor, because it's rendered with tag.
I made a patch to configure whether to use <drupal-media> or <img>, and by enabling <img> tag, you can easily resize images imported via Media Library in CKEditor by drag drop.

Here is the issue link with the patch. It 's built for 9.5x dev, and hope they will merge this feature into new Drupal core update.

https://www.drupal.org/project/drupal/issues/3359725 ✨ CKEditor5, Provide a way to embed Media Image as primitive image in editor, to enable image edit functions Closed: duplicate

Build js in prod mode.

Code standard fix included.

Fix code standard.

Added configuration checkbox, whether use <drupal-medai> or <img> in Filter Option as shown in screenshot below:

@Wim Leers You are mis-reading my intention.
I do not want that display mode options actually here.

I love image resizing function in CKEditor5 (by drag and drop), and I just want it for Media Image, too.
That's why I made this issue to create a patch.

However I do not demand to merge my fix into Core, as mine is just a workaround.

Having media library view mode available is good call, but sometimes users do not want that much, just they want simply drag drop.

When to add image from Drupal media, it now uses rather than to get benefits of image operation.

Austin986 → created an issue.

Austin986 → created an issue.

Austin986 → created an issue.

Closing as handled in Multiple multiday events the second event is not showing on the next row. It is showing in the column after first event colspan ends. 🐛 Multiple multiday events the second event is not showing on the next row. It is showing in the column after first event colspan ends. Needs work

This issue was fixed on the patch here:

3255924-multiday-rendering-fix-merged.patch 🐛 Multiple multiday events the second event is not showing on the next row. It is showing in the column after first event colspan ends. Needs work

@solideogloria no problem. Take as much time as needed please.

I tested several cases on my own project. (I was motivated to contribute cuz I really need to use this module with Multiday events, and seems no one is working on fix.)
So far so good in my current project scope, so I do not mind if it takes some time to review.

This is patch of merged branch, meant to be the final patch.

@solideogloria I have merged 3255924-multiple-multiday-events branch into my branch.
Now my branch 3255924-multiday-rendering-fix has all fixes in this thread so far.

Final patch for complete fix for multiday event issues.

This patch has improvements so that all events are filled up not allowing empty spaces.
If you prefer to place each single day event in new row, please use 3255924-multiday-rendering-fix-v2.0.patch

Austin986 → created an issue.

Added following code to avoid error case:

if (is_null($replace_value)) continue;

Austin986 → created an issue.

@apaderno Can you explain how you solved this issue?

Seems I have same problem here, like I can not push my code, always asking me to Sign In, but nothing of it will work.

Austin986 → created an issue.

Complete fix for multiday events in Month / Week view

This patch fixes multiday events rendering issues for following cases:

• Month View
  • Display multi-day item as a single column
• Display multi-day item as a multiple column row