- Status changed to Needs review
over 1 year ago 1:12pm 30 January 2023 - Status changed to Needs work
over 1 year ago 11:29pm 30 January 2023 - π§π·Brazil RenatoG Campinas
+++ b/src/Plugin/WebformElement/WebformSignature.php @@ -270,11 +271,35 @@ class WebformSignature extends WebformElementBase implements WebformElementFileD + protected function getImageUrl(array $element, WebformSubmissionInterface $webform_submission, array $options = []) { + $image_uri = $this->getImageUri($element, $webform_submission, $options); + if ($image_uri === '') { + return ''; + }
I think we can verify the method first before set the value in the variable right?
What do you think about?
protected function getImageUrl(array $element, WebformSubmissionInterface $webform_submission, array $options = []) { if ($this->getImageUri($element, $webform_submission, $options) === '') { return ''; } $image_uri $this->getImageUri($element, $webform_submission, $options);
- Status changed to Needs review
over 1 year ago 11:40pm 30 January 2023 - π§π·Brazil RenatoG Campinas
Updated the MR with this improved
Lines: https://git.drupalcode.org/project/webform/-/merge_requests/215/diffs#1f... and https://git.drupalcode.org/project/webform/-/merge_requests/215/diffs#1f...
- Status changed to RTBC
over 1 year ago 5:26pm 31 January 2023 - π§π·Brazil joaopauloc.dev
Hello folks, I tested this issue, and works fine.
Steps followed.
1 - Installed webform and webform attachments
2 - Created a new webform with only the Signature element
3 - Checked if the option Attachments appeared on the handler email settings.
4 - Mark option attachments.
5 - Configured the body content to send the signature value
6 - Send a submission to the form.
7 - Using debug I could see the attachment on the email with a link to the signature image.
8 - Using mailhog I could access the email sent and download the signature image.Follow the screenshot for evidence.
Good job @agoradesign and @RenatoG !!!
- First commit to issue fork.
- last update
over 1 year ago 533 pass - π¨π¦Canada Austin986
This patch does not work, and showing error because of file_create_url used.
Updates
- Made a fix
- Added new Item Format - File name, so that item simply can be printed with it's file name.
- last update
over 1 year ago 533 pass - last update
over 1 year ago 533 pass - last update
11 months ago 535 pass - last update
11 months ago Composer require-dev failure - last update
11 months ago Composer require-dev failure - Status changed to Needs review
11 months ago 6:47pm 5 October 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
There is no test coverage for this patch and I am not sure it should be commited
HI, I upgraded to webform 6.3 and the same problem is back.
I applied the patch when It was version 6.2 and the problem was fixed.
the patch is still included in composer.json "enable-patching": true,
"patches": {
"drupal/webform": {
"Add signature as attachement2": " https://www.drupal.org/files/issues/2023-05-19/3303027-signature-attachm... β "
}
}
},