- Issue created by @karlshea
- Merge request !27Check for blazies in withViewsField before trying to call set() → (Merged) created by karlshea
- Status changed to Needs review
7 months ago 4:17pm 26 June 2024 - 🇮🇩Indonesia gausarts
Thank you.
Mind updating it as coalesce in the condition? Just to be short, but fibe without it, though.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
Do you mean
$settings['blazies']?->set('unlazy', FALSE);
? If I do that I get a "Undefined array key "blazies"" warning. - 🇮🇩Indonesia gausarts
Sorry, I meant removing the second line directly into, and replacing the
isset
condition:
if ($blazies = $settings['blazies'] ?? NULL) {
- 🇺🇸United States karlshea Minneapolis 🇺🇸
That makes way more sense lol it's been a long day!
-
gausarts →
committed 735dbf23 on 3.0.x authored by
KarlShea →
Issue #3457375 by KarlShea: BlazyViews::withViewsField calls set() on...
-
gausarts →
committed 735dbf23 on 3.0.x authored by
KarlShea →
- Status changed to Fixed
7 months ago 2:58am 27 June 2024 - 🇮🇩Indonesia gausarts
I went to bed early at 2AM :)
This regression was due to core breaking change with the removal of
$view->element['#attributes']
in views_pre_render. Likely for quite a while, but I just realized it recently. That was why refactored into preprocess_views_view, and things broken with Views field when empty.Fixing one thing breaking others thingies :)
Thanks again for contribution.
- 🇺🇸United States karlshea Minneapolis 🇺🇸
Lots of core stuff hitting me recently too!
Automatically closed - issue fixed for 2 weeks with no activity.