- Issue created by @makbay
- last update
about 1 year ago 4 pass - Status changed to Needs review
about 1 year ago 8:17pm 14 December 2023 - last update
11 months ago 4 pass - last update
11 months ago 4 pass - 🇬🇷Greece emberhood
Attaching a patch adding respect of parent enable check of term link.
This is considered needed in case of conflict with work done in other places like this one: https://www.drupal.org/files/issues/2023-10-13/taxonomy_menu-hide_empty_... →
- 🇮🇳India Sandeep_k New Delhi
Hi, I've Tested MR- MR !9 mergeable on Drupal version- 10.1.9-dev. The MR was applied successfully and looks good to me.
Testing Steps:
- Set up Drupal 10.1.9.
- Download/Enable the Taxonomy Menu module.
- Create Taxonomy Menu> Create new terms> Published & unpublished. You can see unpublished terms are also showing in the menu, Added before results
- Download the shared patch & apply.
- Go back to the site home & Reverify the menu.
Testing Results:
After applying the patch, the Unpublished terms are not showing now. - 🇹🇼Taiwan g-brodiei
Hi, we've met the same issue on a use case to render a taxonomy menu by linkset feature.
We're using Drupal 10.2.5, taxonomy_menu 3.6
The test in merge request does not update the menu item shown in linkset endpoint, please see the gif below where I'd unpublished the term.
Steps with old patch:
- Unpublished term
- Refresh to check menu item disabled, yes
- Refresh endpoint of linkset menu to have menu item disappear, still exists
I've figured out another fix that successfully updates the menu item's "enabled" property while also affects linkset endpoint.
Steps with new patch:
- Unpublished term
- Refresh to check menu item disabled, yes
- Refresh endpoint of linkset menu to have menu item disappear, the unpublished menu item disappears as well