- π³πΏNew Zealand quietone
This extension is being deprecated, see π± [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, π [11.x] [Meta] Tasks to remove Book Active .
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project β and the Extensions approved for removal β policies.
This issue may be re-opened if it can be considered critical β , If unsure, re-open the issue and ask in a comment.
- Status changed to Needs work
7 months ago 10:25pm 1 May 2024 - πΊπΈUnited States smustgrave
Lets see if we can land this for 2.0.x
- Merge request !48Allow book navigation title to be overridden by top-level node title β (Merged) created by karlshea
- πΊπΈUnited States karlshea Minneapolis πΊπΈ
MR created against 2.0.x with most of #95.
I'm not sure where some of the tests for Drupal 8 should be (if anywhere at all), so that didn't make it in.
There also seems to be an issue in testBookNavigationBlockWithTopLevelPageTitle. I'm not sure what's going on there, the patch works on my local copy but when the test runs it can't find the block by ID.
- πΊπΈUnited States smustgrave
Lets try this. I think the tests were written with a specific theme installed. Stark is very basic
- πΊπΈUnited States smustgrave
That worked! Also manually tested and appears to work and addresses π book_title variable in book-navigation.html.twig contains the page title Needs work
- πΊπΈUnited States karlshea Minneapolis πΊπΈ
Oh it was totally the missing context_mapping! I had to fix that on the actual site I was working on *facepalm*
- πΊπΈUnited States smustgrave
Yea would love to be able to make it required if that book setting is selected but don't see it in the form array
Automatically closed - issue fixed for 2 weeks with no activity.