book_title variable in book-navigation.html.twig contains the page title

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This needs an issue summary update, see Write an issue summary for an existing issue → for guidance. And the title doesn't seem quite right, the code is adding a variable.

1. +++ b/core/modules/book/book.module
   @@ -363,7 +363,7 @@ function book_form_node_confirm_form_alter(&$form, FormStateInterface $form_stat
   +function template_preprocess_book_all_books_block(array &$variables) {
   

   out of scope

2. +++ b/core/modules/book/book.module
   @@ -438,7 +442,7 @@ function template_preprocess_book_navigation(&$variables) {
   +    \Drupal::service('renderer')->renderPlain($build);
   

   Why this change?

3. +++ b/core/modules/book/tests/src/Functional/BookTest.php
   @@ -390,6 +391,26 @@ public function testGetTableOfContents() {
   +  public function testBookNavigationBlockBookTitleAndUrl() {
   

   Instead of adding another functional test can this be added to an existing test without compromising that test.

4. +++ b/core/modules/book/tests/src/Functional/BookTest.php
   @@ -390,6 +391,26 @@ public function testGetTableOfContents() {
   +    $this->assertEquals($this->book->book['link_title'], $variables['book_title'], 'Valid book title when displaying navigation for a child node.');
   ...
   +    $this->assertEquals($expected_book_url, $variables['book_url'], 'Valid book url when displaying navigation for a child node.');
   

   Messages are no longer used in assertions in Drupal, except in special circumstances like loops.

This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.

So this seems like a bug for sure and could have some breakage. So I added link_title to the template also so both current and book links are available. 2.0.x is in alpha so making the assumption sites are testing each update and not blindly updating. Also published a CR and addressed #68

Lots of comments but tried my best with credit (not including plain re-rolls with no interdiffs or addressing feedback.)

So I actually reverted this as I found ✨ Allow book navigation title to be overridden by top-level node title Postponed which seems like a better solution.

Will keep as fixed though for those who worked on this get their credit.

Automatically closed - issue fixed for 2 weeks with no activity.