Account created on 19 September 2007, about 17 years ago
  • Senior Web Developer at ISSUPΒ 
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom jacktonkin

Updated composer.json to allow drupal/domain ~1.0 or ~2.0.0.

I've added this here as domain 2.0.0-beta1 is required to support Drupal 10 and has minimal changes from 8.x-1.0-beta8. Also, πŸ› Update Domain_group 2.x version to work with Domain 2.x version Closed: duplicate has been closed as a duplicate of work on the 3.x branch.

πŸ‡¬πŸ‡§United Kingdom jacktonkin

jacktonkin β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom jacktonkin

Upgrade Status is also finding deprecation notices in some test files but I think they are both PHPUnit 10 things:

  • Call to deprecated method prophesize() of class Drupal\Tests\moodle_rest_migrate\Kernel\Plugin\migrate\process\MoodleFileTest
  • Call to deprecated method withConsecutive() of class PHPUnit\Framework\MockObject\Builder\InvocationMocker
πŸ‡¬πŸ‡§United Kingdom jacktonkin

There are also entity queries in moodle_rest_user module that don't specify access checks. I've added these as follows:

  • Checking access in Drupal\moodle_rest_user\Controller\CourseController since this is the default in Drupal 9
  • Skipping access checks in Drupal\moodle_rest_user\UserBatchHelper since this is only used by a Drush command so presumably that's more appropriate?
πŸ‡¬πŸ‡§United Kingdom jacktonkin

jacktonkin β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom jacktonkin

Re-rolled against 2.0.x

πŸ‡¬πŸ‡§United Kingdom jacktonkin

The attached patch removes access checking when finding content to migrate and explicitly includes access checking when looking for existing media entities to avoid creating duplicates.

Production build 0.71.5 2024