Can't scroll vertical toolbar tray to reveal last item, applies to both mobile and desktop breakpoints

Created on 8 July 2016, over 8 years ago
Updated 14 March 2023, over 1 year ago

I've seen this issue in Chrome, Firefox and Safari on Mac with version 8.1.5 installed. I didn't check Windows/IE.

Due to a padding-top of 39px, the vertical toolbar tray can't be scrolled to reveal the last item (which is "Help")

You can see this behavior from the attached gif. It's a bit hard to see from the gif, but if you look closely, there's a menu item "Help" at the bottom before the menu expands, then an attempt is made to scroll down to "Help" again, but the scrolling can't go beyond "Reports", meaning there's no way to access the "Help" item from the vertical sidebar when there's a scroll bar shown.

🐛 Bug report
Status

Needs work

Version

9.5

Component
Toolbar 

Last updated 9 days ago

  • Maintained by
  • 🇫🇷France @nod_
Created by

🇳🇴Norway svenryen

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India Shubham Sharma 77

    Applied patch #56 applied successfully in drupal-9.5.x-dev
    Thanks for the patch
    For ref sharing screenshots...

  • 🇳🇴Norway svenryen

    @Shubham Sharma 77, thanks for reviewing the patch.

    We should set status to Reviewed and tested by the community if you've properly reviewed the patch, so that this can go into core. Can you please update the status?

    I looked at the code and it seems ok, standard wise.

  • Status changed to RTBC almost 2 years ago
  • 🇮🇳India saket-001

    patch #56 worked successfully.

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Re #56

    index 87c8fc5b3f..81aced9879 100644
    --- a/core/modules/toolbar/js/views/ToolbarVisualView.es6.js
    +++ b/core/modules/toolbar/js/views/ToolbarVisualView.es6.js
    @@ -316,10 +316,25 @@
            */
           adjustPlacement() {

    Drupal no longer uses.es6.js files. If this qualifies for a 9.x backport that could happen there. For now, this should target the current dev branch, 10.1.x.

    diff --git a/core/modules/taxonomy/src/TermForm.php b/core/modules/taxonomy/src/TermForm.php
    index af287ba881..d8603582e7 100644
    --- a/core/modules/taxonomy/src/TermForm.php
    +++ b/core/modules/taxonomy/src/TermForm.php
    @@ -211,8 +211,13 @@ public function save(array

    Why is TermForm being changed?

    And we're good on Screenshots. Please no more screenshots.

  • 🇮🇳India _utsavsharma

    Addressed 1 from #62 as i updated the js files for 10.1.x.
    Could not address the second point.

  • 🇮🇳India kunals131

    @_utsavsharma Applied patch #63 for 10.1.x

    before-patch-63.gif
    after-patch-63.gif

Production build 0.71.5 2024