Fix the issues reported by phpcs

FILE: /app/modules/contrib/media_entity_download/src/Controller/DownloadController.php ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 19 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ----------------------------------------------------------------------------------------------------------------- FILE: /app/modules/contrib/media_entity_download/src/Plugin/Field/FieldFormatter/DownloadLinkFieldFormatter.php --------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------------------------------- 44 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 45 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 84 | WARNING | [x] '@todo: replace with DI when this issue is fixed: https://www.drupal.org/node/2053415' should match the format '@todo Fix problem X here.' --------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /app/modules/contrib/media_entity_download/src/Plugin/Linkit/Substitution/MediaDownload.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 82 | WARNING | [x] '@todo: Discover if we can support file field deltas at some point via the suggestion matcher.' should match the format '@todo Fix problem X here.' ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇳India Charchil Khandelwal
Charchil Khandelwal → made their first commit to this issue’s fork.
@charchil-khandelwal opened merge request.
Comment over 1 year ago →
🇮🇳India Charchil Khandelwal
Created MR for this issue.
Please review.
Comment over 1 year ago →
🇮🇳India Akram Khan Cuttack, Odisha
Review the patch it apply cleanly and there are no PHPCS error. added SS
Status changed to RTBC over 1 year ago8:43am 20 February 2023
Comment over 1 year ago →
🇮🇳India Akram Khan Cuttack, Odisha
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work over 1 year ago2:45pm 3 March 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
- * DownloadController class. + * The DownloadController class.
Adding the article is not sufficient to fix the documentation comment for a class.

- // @todo: replace with DI when this issue is fixed: https://www.drupal.org/node/2053415 + // @todo replace with DI when this issue is fixed: https://www.drupal.org/node/2053415
What follows @todo is a sentence: The first word is written in capital case and the sentence ends with a period.
First commit to issue fork.
Merge request !103328756: Phpcs fixes → (Merged) created by kkalashnikov
Status changed to Needs review over 1 year ago11:01am 21 March 2023
Comment over 1 year ago →
🇮🇳India saket-001
MR !10 fixes the all PHPCS issue and also changes are mention as in #9.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to RTBC over 1 year ago5:52pm 29 March 2023
Comment over 1 year ago →
🇮🇳India saket-001
Moving to RTBC as patch applied successfully and worked fine .
First commit to issue fork.
Comment 4 months ago →
🇺🇸United States kevinquillen
There are remaining issues for Drupal 11. Will merge what we have and for the rest the discussion is here 📌 New 3.0.x branch? Active .
Pipeline finished with Skipped
4 months ago
#179430
Comment 4 months ago →
System Message

kevinquillen → committed dbda5eda on 8.x-2.x authored by kkalashnikov →
Issue #3328756 by kevinquillen: Fix the issues reported by phpcs
Status changed to Fixed 4 months ago3:24pm 22 May 2024
Comment 4 months ago →
🇺🇸United States kevinquillen
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!10Fix the issues reported by phpcs
Merged

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!10Fix the issues reported by phpcsMerged

Comments & Activities

!10Fix the issues reported by phpcs
Merged