Change page title "Content language" when Content Translation module is enabled

under comment #33 i had applied both failed and pass patches of #34. Adding screenshot for both the patches.

Some things need addressing.

1. +++ b/core/modules/language/language.routing.yml
   @@ -81,7 +81,7 @@ language.negotiation_browser_delete:
   +    _title_callback: '\Drupal\language\Controller\TitleController::setTitle'
   

   This can be a method in ContentLanguageSettingsForm, no need to make a dedicated controller for it.

   The method should also be named getTitle, nothing is being set.

2. +++ b/core/modules/language/src/Controller/TitleController.php
   @@ -0,0 +1,55 @@
   +   * Constructs the BlockListController.
   

   This is not a BlockListController, but probably a non-issue as this whole thing can probably be discarded in favor of a method added to ContentLanguaggeSettingsForm

3. +++ b/core/modules/language/src/Controller/TitleController.php
   @@ -0,0 +1,55 @@
   +   * @return string
   

   This returns @return \Drupal\Core\StringTranslation\TranslatableMarkup

Also note we have more than enough screenshots so those can stop. They won't get credit so it's not worth anyone's time. There's test coverage to account for anything that changes going forward.

I applied the suggestions in #43. Please review.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

1 open thread still in the MR 1107

Damn, I thought I had deleted it.

Think we are good now!

Committed 5b399ae and pushed to 10.1.x. Thanks!

I removed credit for screenshots here since the text change is covered by automated test coverage.

Automatically closed - issue fixed for 2 weeks with no activity.