Incorrect access denied messages in branding block

Rerolled #27
error: patch failed: core/modules/block/tests/src/Functional/BlockSystemBrandingTest.php:119
error: core/modules/block/tests/src/Functional/BlockSystemBrandingTest.php: patch does not apply

tested and verified patch #38 on claro and olivero themes, patch applied successfully and fixed the 'Incorrect access denied messages in branding block', attaching screenshots for reference. need RTBC+1

patch #38 is working fine. also mentioned in #39 so moving status to RTBC.

+++ b/core/modules/block/tests/src/Functional/BlockSystemBrandingTest.php
@@ -115,6 +115,17 @@ public function testSystemBrandingSettings() {
+    $this->assertSession()->responseNotContains('Defined on the Appearance or Theme Settings page. You do not have the appropriate permissions to change the site logo.');
+    $this->assertSession()->responseNotContains('Defined on the Site Information page. You do not have the appropriate permissions to change the site logo.');
+    $this->assertSession()->responseNotContains('Defined on the Site Information page. You do not have the appropriate permissions to change the site logo.');

We never emit 'You do not have the appropriate permissions' anymore, so these assertions would still pass even if the patch didn't work.

Let's change them to assert the new string isn't emitted.

Let's also add some positive asserts for the user that does have the required permissions

added updated patch and addressed #41

Applied the latest patch and converted to a merge request. Fixed the test coverage and found a bug with the active theme and fixed that too.

I have reviewed and tested the patch against Drupal 11.x-dev, and it works as expected. The patch successfully removes the incorrect access denied messages that appeared in the Site Branding block when users lacked permission to edit certain elements. Specifically, users without the appropriate permissions no longer see misleading references such as "You do not have the appropriate permissions to change the site logo" when they only lack access to the site name or slogan.