tanuj. → created an issue.
please let me know when we might expect an official Drupal 11 release for this module?
Thanks for working on this, it is an essential module for my D11 project so Any updates or estimated D11 release dates would be greatly appreciated!
please let me know when we might expect an official Drupal 11 release for this module?
Just checking on when the next release for Drupal 11 support for this contrib module will be. I’m looking to upgrade site to Drupal 11, and this module is essential for the project. Any updates or estimated release dates would be greatly appreciated!
Tanuj. → made their first commit to this issue’s fork.
Tanuj. → made their first commit to this issue’s fork.
Created new branch and MR for second solution also updated Issue summary. Please review.
Tanuj. → changed the visibility of the branch 3422758-no-focus-on to hidden.
Tanuj. → made their first commit to this issue’s fork.
Tanuj. → made their first commit to this issue’s fork.
Tanuj. → created an issue.
Removed cursor pointer for form label, it was not related to only blocks but this was throughout Drupal in editing node form or having exposed form in views. created a MR for this please review.
Tanuj. → made their first commit to this issue’s fork.
Added a change record → for this issue. Please review.
Tested and verified this MR and it fixes the issue, this happens with both private and public video because of enabling this Enable Display field option in Video field setting as stated by @sijumpk. attaching screenshots for reference. RTBC++
Converted patch to MR and added tests to it. Please review.
Tanuj. → made their first commit to this issue’s fork.
hey sure @smustgrave will keep that in mind. thanks
Tanuj. → made their first commit to this issue’s fork.
Tanuj. → made their first commit to this issue’s fork.
That's what the patch does it removes the extra X icon from chrome as it is generated by default for input[type="search"] field in chromium based browsers but this extra X is not present in Firefox browser.
--- a/css/module_filter.modules_tabs.css
+++ b/css/module_filter.modules_tabs.css
@@ -109,6 +109,12 @@
.modules-tabs__pane input.table-filter-text {
width: 100%;
}
+.modules-tabs__pane input[type="search"]::-webkit-search-decoration,
+.modules-tabs__pane input[type="search"]::-webkit-search-cancel-button,
+.modules-tabs__pane input[type="search"]::-webkit-search-results-button,
+.modules-tabs__pane input[type="search"]::-webkit-search-results-decoration {
+ -webkit-appearance:none;
+}This code present in the patch/MR removes that extra X from chromium based browsers, also this extra X icon present by default doesn't update the search results and simply clears the text from field.
Tested and verified this issue on drupal 10.2 and patch #2 works fine and fixes the issue of 'X' icon alignment in search bar and also removes the additional 'X' icon which shows up on chrome and safari browser as stated in #4. Attaching before and after screenshots for Firefox and chrome browser. RTBC++
It seems to me that this isn't an issue for this module, but rather a bug in the core CKEditor5, and it could be linked to this. -
https://www.drupal.org/project/drupal/issues/3405440
🐛
Ckeditor 5 is wrapping html tags inside p tag
Active
. CKeditor5 wraps all elements inside <p></p> which is breaking the UI.
The bug was reproducible on drupal 10.1 and 11. Tested and reviewed this MR manually which fixes the focus issue for current_password field. Attaching before and after screenshots for better clarity of this issue. changing the status to NR again.
Before
After
Tanuj. → made their first commit to this issue’s fork.
hey @quicksketch tried a different approach to handle this, instead of changing the warning message i tried to improve the UI for toolbar with more focus on buttons so it doesn't feel like a footer. this will also tackle the situation where if the layout has more elements the message stays on top of page and the user just scrolls past it this new button design will be visible clearly to user in such case.
attaching a patch for this, if this solutions looks good will create a MR.
Reviewed and tested the MR. It helps improve the UX and makes it easier for users to navigate through the layout builder. attaching before and after gif to show the improvements in UI.
RTBC++
Did a little digging related to this blank option in select list, turns out it was put in intentionally. Found two issues related to this
Do not add a section when editing an empty layout, or differentiate between new layouts and existing empty layouts →
&
Rename SectionStorageTrait to SectionListTrait →
so idk if this is good idea to remove the blank select option and what complications or bugs it might cause if we remove it. might need some inputs and review of others before pushing a merge request or patch so moving it to needs review.
also this issue is not related to claro theme but layout builder module or field layout module hence updating it.
Tested the merge request and it solves the spacing issue, attaching before and after screenshots for this. RTBC++
Hey @Nitin-shrivastava, I am unable to reproduce this issue because I was unable to locate the layout settings option on 'Manage Form Display' for any content type, maybe it persists within 'Manage Display' tab which has 'Manage Layout' button. I have tried it with Claro, Olivero and some contributed themes but the outcome is same, this issue maybe is related to some specific contrib theme and not core issue. Please update steps to reproduce.
Filters and search are still missing from dashboard, updating the version to 2.x.
Adding a patch file that adds Date Range Filter and Keyword Search field to search for Title, Email address & Body from Mail.
Tanuj. → made their first commit to this issue’s fork.
Tanuj. → made their first commit to this issue’s fork.
@djsagar i tested this on drupal 10.1 and 9.5 with gin version 8.x-3.x. i was able to reproduce it.
I was able to reproduce this on drupal 10.1. tested and verified the MR and it solves the issue, adding before and after screenshots.
RTBC ++
I was able to reproduce this and tested and reviewed the MR on drupal 10.1, it fixed the spacing issue on dropdown menu. attaching before and after screenshots of it.
RTBC
Tanuj. → created an issue.
I tried to reproduce this bug with french, spanish and hindi language translation on drupal 10.1 and was able to reproduce it, message text was not translating and still showing in default language. after testing @boddy’s MR it didn’t solve the problem for me instead the message texts disappeared, tested with multiple languages but the issue remained same.
adding before and after MR screenshots for this and moving the status to needs work again.
I was able to reproduce this on my local and tested the MR, it fixes the issue with unwanted horizontal scroll bar on table with no header, also MR provided in this issue
🐛
gin-table-scroll-wrapper prevents nested paragraph buttons from being clickable
Fixed
doesn't fix the above mentioned problem for me as well on drupal 10.1 and 9.5.
So adding before and after screenshots after testing the MR provided by @Peacog as it solves the issue.
RTBC+1
will try to reproduce this on my local and test the patch
Was able to reproduce this issue on my local, Reviewed and tested the patch with drupal 10.1 and it solved the above mentioned issue for status message with RTL language. Attaching before and after images for it.
RTBC +1
fixing CCF errors
Noticed there were some grammatical errors in exception messages such as duplicate words in the commit added, so adding a patch for it along with new tests for the function and exceptions messages not sure if it is correct, please review.
Verified and tested patch #2, looks good to me as it removed the unused 'claro/drupal.responsive-detail' library. RTBC +1
Tested and verified the patch it applied successfully and fixed all phpcs errors.
Tested and verified patch, it applied successfully and fixed all the phpcs error, but the patch adds a whitespace error in readme.md file please see screenshot for reference. so updating the patch for same can be moved to RTBC.
Verified and tested the patch and it fixes all the coding standard issues, although idk if we need fix for .js file it seems redundant to me and makes the patch quite big in size, so changing the status to needs work. if you think .js file fix is important feel free to change the status to RTBC
Thanks.
FILE: .../web/modules/contrib/ckeditor5_findandreplace/js/build/find-and-replace.js
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------updated patch according to point addressed in #3, please review.
For latest dev branch getting these below listed phpcs errors.
FILE: /datetime_range_timezone.tokens.inc
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
142 | ERROR | [x] Use "elseif" in place of "else if"
142 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /datetime_range_timezone.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
8 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------
FILE: /tests/src/Kernel/DateRangeTimezoneHelperTrait.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
36 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /tests/src/Kernel/TokenReplacementTest.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
71 | ERROR | [x] Expected 1 blank line after function; 2 found
111 | ERROR | [x] Expected 1 blank line after function; 0 found
112 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /src/Plugin/Field/FieldFormatter/DateRangeTimezone.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
40 | ERROR | [x] Expected 1 space between double arrow and "$item"; 2 found
40 | ERROR | [x] Expected 1 space after "=>"; 2 found
42 | ERROR | [x] Expected 1 space between double arrow and "$item"; 2 found
42 | ERROR | [x] Expected 1 space after "=>"; 2 found
76 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
77 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /src/Plugin/Field/FieldFormatter/DateRangeTimezoneSingleDate.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
71 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
72 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
FILE: /src/Plugin/Field/FieldFormatter/DateRangeTimezoneFormatterBase.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
43 | ERROR | [x] Expected 1 blank line after function; 0 found
44 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------adding a new patch to fix all these errors, please review.
unrelated failure, retest is green. please review.
Verified patch #2 and MR, fixed the spelling mistake issue. changes looks good to me. RTBC.
tested and verified patch #2, it applied successfully and fixed all spelling mistakes in code comments. RTBC
Tested and verified patch #2, patch applied successfully and fixed the spelling mistakes in commented code. patch looks good. RTBC
updated patch after addressing points from #21, still needs tests tho.
Tanuj. → created an issue.
Fixed Tests on #19.
adding new patch for drupal 10.1 as earlier patches were incomplete, please review.
Tested and verified patch #51 with drupal: 10.1.x and the patch applied successfully and fixed the issue of multiple message on page. adding screenshots for reference. RTBC+1
tested and verified patch #38 on claro and olivero themes, patch applied successfully and fixed the 'Incorrect access denied messages in branding block', attaching screenshots for reference. need RTBC+1
Updating patch after addressing points from #25, although i am not sure about how to move forward with point 5. please review.
Fixed CCF on #16, keeping the status to needs work as it still needs tests.
as patch #77 does not applies
error: while searching for:
return $update;
});
}
error: patch failed: core/modules/system/system.post_update.php:93
error: core/modules/system/system.post_update.php: patch does not applyadding a reroll for #77, please review.
Adding a patch to resolve all phpcs errors.
ignored these 2 errors as it contains installation commands
FILE: /docs/enterprise_setup.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 128 characters
----------------------------------------------------------------------
FILE: /docs/freetier_setup.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 128 characters
----------------------------------------------------------------------TanujJain-TJ → created an issue.
Adding a patch to fix the above mentioned phpcs issues.
TanujJain-TJ → created an issue.
Tested and verified patch #2 on drupal:10.1.x, the patch applied successfully but still getting some PHPCS errors after running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
need to fix below mentioned errors, chaning it to needs work again.
FILE: /entity_print/src/Asset/AssetCollector.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
51 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
52 | WARNING | The removal-version 'entity_print:3.0.0' does not match the
| | lower-case machine-name standard: drupal:n.n.n or
| | project:n.x-n.n
--------------------------------------------------------------------------------
FILE: entity_print/src/Asset/AssetRenderer.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
71 | WARNING | Variable $build inside unset call is undefined.
--------------------------------------------------------------------------updated according to #40, please review.
@dpi sorry for that null check i interpreted it wrong at first updating the patch to correct all the changes required, also these out of scope changes are just PHPCS fixes i got while running this, did it so the patch doesn't fail Custom commands check. adding new interdiff with #32.
phpcs --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme,css,info,txt,md,yml"
Adding a new patch addressing points from #34 and #35, and also fixing some phpcs errors. please review.
mherchel → credited TanujJain-TJ → .
As patch #15 doesn't apply and throws error,
error: patch failed: src/CognitoToken.php:184
error: src/CognitoToken.php: patch does not apply
error: patch failed: src/Form/Email/UserLoginForm.php:192
error: src/Form/Email/UserLoginForm.php: patch does not apply
error: patch failed: src/Plugin/rest/resource/CognitoUserRegistrationResource.php:200
error: src/Plugin/rest/resource/CognitoUserRegistrationResource.php: patch does not apply
error: patch failed: tests/src/Kernel/Email/LoginFormTest.php:20
error: tests/src/Kernel/Email/LoginFormTest.php: patch does not applyadding a new patch to remove phpcs errors and addressing points from #12, #14, #17, please review.
patch #25 doesn't apply on drupal 10.1.x and throws this error
Checking patch core/modules/language/src/Plugin/LanguageNegotiation/LanguageNegotiationContentEntity.php...
error: while searching for:
// url.
// First, check if processing conditions are met.
if (!($request && !empty($options['route']) && $this->hasLowerLanguageNegotiationWeight() && $this->meetsContentEntityRoutesCondition($options['route'], $request))) {
return $path;
}
error: patch failed: core/modules/language/src/Plugin/LanguageNegotiation/LanguageNegotiationContentEntity.php:105
error: core/modules/language/src/Plugin/LanguageNegotiation/LanguageNegotiationContentEntity.php: patch does not applyadding a new patch to fix CCF on #28, adding interdiff and reroll diff. please review
Adding a new patch addressing points from #11, please review.
after applying #8 got this phpcs error
FILE: /src/Form/EntitySchemaConfigurationForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
272 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
273 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: src/Plugin/DataType/SchemaOverrides.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | WARNING | Unused variable $override.
--------------------------------------------------------------------------------Adding a new patch to fix this error and for now commenting the code to remove unused variable error as it was todo, also addressing changes mentioned in #14.