Fix the issues reported by phpcs

FILE: tests/modules/cloudflare_form_tester/src/Mocks/ComposerDependenciesCheckMock.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 51 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead -------------------------------------------------------------------------------- FILE: tests/modules/cloudflare_form_tester/src/Mocks/ZoneMock.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 135 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead -------------------------------------------------------------------------------- FILE: /tests/src/Unit/ClientIpRestoreTest.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------- 13 | WARNING | [x] Unused use statement 92 | WARNING | [x] A comma should follow the last multiline array item. | | Found: $bypass_host 101 | WARNING | [x] A comma should follow the last multiline array item. | | Found: ] -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /tests/src/Functional/CloudFlareAdminSettingsFormTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 16 | ERROR | [x] Missing class doc comment -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /tests/src/Functional/ComposerDependencyTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 15 | ERROR | [x] Missing class doc comment -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /tests/src/Functional/CloudFlareAdminSettingsInvalidFormTest.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 18 | ERROR | [x] Missing class doc comment 85 | WARNING | [ ] Unused variable $mock. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /tests/src/Functional/VariousUseCasesTest.php -------------------------------------------------------------------------------- FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES -------------------------------------------------------------------------------- 12 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters 17 | ERROR | [x] Missing class doc comment 40 | ERROR | [x] Expected 1 blank line before function; 2 found 59 | ERROR | [ ] Doc comment short description must be on a single line, | | further text should be a separate paragraph 91 | WARNING | [x] A comma should follow the last multiline array item. | | Found: ] 114 | ERROR | [x] Expected 1 blank line after function; 2 found 126 | ERROR | [x] Expected 1 blank line after function; 2 found 132 | ERROR | [ ] Missing parameter type 145 | ERROR | [ ] Missing parameter type -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /docs/enterprise_setup.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 128 characters 5 | WARNING | Line exceeds 80 characters; contains 197 characters 14 | WARNING | Line exceeds 80 characters; contains 85 characters 15 | WARNING | Line exceeds 80 characters; contains 197 characters 16 | WARNING | Line exceeds 80 characters; contains 213 characters ---------------------------------------------------------------------- FILE: /docs/freetier_setup.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 128 characters 5 | WARNING | Line exceeds 80 characters; contains 197 characters 15 | WARNING | Line exceeds 80 characters; contains 85 characters 16 | WARNING | Line exceeds 80 characters; contains 197 characters 17 | WARNING | Line exceeds 80 characters; contains 213 characters ---------------------------------------------------------------------- FILE: /docs/disclaimers.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 2 | WARNING | Line exceeds 80 characters; contains 187 characters 7 | WARNING | Line exceeds 80 characters; contains 312 characters 15 | WARNING | Line exceeds 80 characters; contains 103 characters ---------------------------------------------------------------------- FILE: README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES ---------------------------------------------------------------------- 2 | WARNING | Line exceeds 80 characters; contains 124 characters 6 | WARNING | Line exceeds 80 characters; contains 115 characters 9 | WARNING | Line exceeds 80 characters; contains 86 characters 30 | WARNING | Line exceeds 80 characters; contains 117 characters 31 | WARNING | Line exceeds 80 characters; contains 119 characters 32 | WARNING | Line exceeds 80 characters; contains 118 characters 36 | WARNING | Line exceeds 80 characters; contains 117 characters 38 | WARNING | Line exceeds 80 characters; contains 118 characters 47 | WARNING | Line exceeds 80 characters; contains 86 characters ---------------------------------------------------------------------- FILE: cloudflare.install ------------------------------------------------------------------------------ FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------ 51 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 54 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 63 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found 66 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found 69 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: /src/Form/SettingsForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 25 | WARNING | The class short comment should describe what the class does | | and not simply repeat the class name 367 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: /src/Form/ZoneSelectionForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 20 | WARNING | The class short comment should describe what the class does and | | not simply repeat the class name --------------------------------------------------------------------------------

Comments & Activities

Issue created by @TanujJain-TJ

Comment over 2 years ago →

🇮🇳India TanujJain-TJ

Adding a patch to resolve all phpcs errors.

ignored these 2 errors as it contains installation commands

FILE: /docs/enterprise_setup.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 4 | WARNING | Line exceeds 80 characters; contains 128 characters
----------------------------------------------------------------------


FILE: /docs/freetier_setup.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 4 | WARNING | Line exceeds 80 characters; contains 128 characters
----------------------------------------------------------------------

Status changed to Needs review over 2 years ago2:56pm 5 April 2023
Comment over 2 years ago →
🇮🇳India TanujJain-TJ
Comment over 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to RTBC over 2 years ago3:19pm 2 May 2023
Comment over 2 years ago →
🇵🇭Philippines kenyoOwen
Hi tanuj

I applied patch #2 to the “CloudFlare” module against Version 2.0.x-dev and confirmed that the errors and warnings are resolved and the remaining issue is ignored since it is an installation command. Please see the screenshots attached.

For your review.
Thank you.
Status changed to Needs work over 2 years ago4:17pm 2 May 2023
Comment over 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
/** - * Class SettingsForm. + * Creates Settings Form.
I am not sure Creates is the right verb.
Settings and Form are misspelled, since they are not the first word in the phrase.

+ /** + * The state store. + * + * @var Drupal\Core\State\StateInterface + */ + protected $state;
+ * @param Drupal\Core\State\StateInterface $state + * The object State.
That service is usually described as The state key/value store.
Assigned to imustakim
Comment about 2 years ago →
🇨🇦Canada imustakim Canada
Working on this.
Issue was unassigned.
Status changed to Needs review about 2 years ago1:59pm 3 May 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
Unable to generate test groups
Comment about 2 years ago →
🇨🇦Canada imustakim Canada
Patch updated.
Please review.
Comment over 1 year ago →
bindu r
Hi, Reviewed the patch at #8, applies cleanly and addresses the comment #6, but found few warnings. Attaching the ss for reference.
Comment about 1 year ago →
🇮🇳India dev16.addweb
Re-roll the patch #8 according to the latest code changes.
Merge request !20Issue #3352408: Fix the issues reported by phpcs → (Open) created by apaderno
Pipeline finished with Canceled
about 1 year ago
Total: 46s
#193471
Pipeline finished with Failed
about 1 year ago
Total: 149s
#193474
Merge request !21Issue #3352408: Fix the issues reported by phpcs → (Merged) created by apaderno
Pipeline finished with Canceled
about 1 year ago
Total: 42s
#193521
Pipeline finished with Failed
about 1 year ago
Total: 163s
#193524
Comment about 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Pipeline finished with Running
about 1 year ago
#193538
Comment about 1 year ago →
🇵🇹Portugal jcnventura
jcnventura → changed the visibility of the branch 3352408-fix-the-issues to hidden.
Pipeline finished with Failed
about 1 year ago
Total: 185s
#206871
First commit to issue fork.
Pipeline finished with Skipped
3 days ago
#561054
Comment 3 days ago →
System Message

rosk0 → committed 38842814 on 2.0.x authored by avpaderno →
Issue #3352408 by avpaderno, imustakim, tanuj., jcnventura: Fix the...
Comment 3 days ago →
🇳🇿New Zealand RoSk0 Wellington
Thanks

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!21Fix the issues reported by phpcs
Merged

!20Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!21Fix the issues reported by phpcsMerged

!20Fix the issues reported by phpcsOpen

Comments & Activities

!21Fix the issues reported by phpcs
Merged

!20Fix the issues reported by phpcs
Open