- Issue created by @TanujJain-TJ
- ๐ฎ๐ณIndia TanujJain-TJ
Adding a patch to resolve all phpcs errors.
ignored these 2 errors as it contains installation commands
FILE: /docs/enterprise_setup.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 128 characters ---------------------------------------------------------------------- FILE: /docs/freetier_setup.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 128 characters ----------------------------------------------------------------------
- Status changed to Needs review
over 1 year ago 2:56pm 5 April 2023 - Status changed to RTBC
over 1 year ago 3:19pm 2 May 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi tanuj
I applied patch #2 to the โCloudFlareโ module against Version 2.0.x-dev and confirmed that the errors and warnings are resolved and the remaining issue is ignored since it is an installation command. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Needs work
over 1 year ago 4:17pm 2 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** - * Class SettingsForm. + * Creates Settings Form.
I am not sure Creates is the right verb.
Settings and Form are misspelled, since they are not the first word in the phrase.+ /** + * The state store. + * + * @var Drupal\Core\State\StateInterface + */ + protected $state;
+ * @param Drupal\Core\State\StateInterface $state + * The object State.
That service is usually described as The state key/value store.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:59pm 3 May 2023 - last update
over 1 year ago Unable to generate test groups Hi, Reviewed the patch at #8, applies cleanly and addresses the comment #6, but found few warnings. Attaching the ss for reference.
- ๐ฎ๐ณIndia dev16.addweb
Re-roll the patch #8 according to the latest code changes.
- ๐ต๐นPortugal jcnventura
jcnventura โ changed the visibility of the branch 3352408-fix-the-issues to hidden.