- Issue created by @dineshkumarbollu
- First commit to issue fork.
- Merge request !6753Issue #3423384: Extra Close icon in Messages → (Closed) created by govind_giri_goswami
- Status changed to Needs review
11 months ago 10:50am 23 February 2024 - 🇮🇳India govind_giri_goswami
changes in closeMessage() function, which adds a close button to a message container if one doesn't already exist, and hides the message when the close button is clicked
- Status changed to Needs work
11 months ago 2:57pm 23 February 2024 - 🇺🇸United States smustgrave
Would be good to add solution to the issue summary.
- 🇮🇳India shreyal999
The code should have indentation or line gap as in the previous version for code clarity.
- First commit to issue fork.
- 🇷🇺Russia kostyashupenko Omsk
Wondering what is the cause of that fact that
once()
in that case doesn't actually work (works 2 times) - Status changed to RTBC
11 months ago 6:18am 4 March 2024 - 🇮🇳India adwivedi008
I tested the MR mentioned in #4, and it fixes the issue
So moving the issue to RTBC - 🇫🇷France nod_ Lille
when bigpipe is enabled, the status message comes from a bigpipe/ajax command.
The message commands adds a new message using Drupal.theme('message') it calls olivero implementation of the theme function that adds a close button. Nothing is using once at this point. Then when the page loads, behaviors are called, and a second close button is added to the message. Once is working as expected it's just not at the right place.
Theme functions should be returning plain strings instead of objects, that would have prevent the double initialization.
Fix makes sense in this situation.
- Status changed to Fixed
11 months ago 10:16am 4 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.