Extra Close icon in Olivero Messages

changes in closeMessage() function, which adds a close button to a message container if one doesn't already exist, and hides the message when the close button is clicked

Would be good to add solution to the issue summary.

Applied MR 6753, Mentioned issue fixed

The code should have indentation or line gap as in the previous version for code clarity.

Gauravvvv → made their first commit to this issue’s fork.

Wondering what is the cause of that fact that once() in that case doesn't actually work (works 2 times)

Confirm MR fixes the issue.

I tested the MR mentioned in #4, and it fixes the issue
So moving the issue to RTBC

nod_ → credited andy-blum → .

nod_ → credited mherchel → .

nod_ → credited Ruturaj Chaubey → .

when bigpipe is enabled, the status message comes from a bigpipe/ajax command.

The message commands adds a new message using Drupal.theme('message') it calls olivero implementation of the theme function that adds a close button. Nothing is using once at this point. Then when the page loads, behaviors are called, and a second close button is added to the message. Once is working as expected it's just not at the right place.

Theme functions should be returning plain strings instead of objects, that would have prevent the double initialization.

Fix makes sense in this situation.

nod_ → closed merge request !6753

Committed 068b95a and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.