Hi, Created Patch for the above issue, Now Sub Menu will be visible on hover of respective list item
Created Patch for the above issue:
pravesh_poonia → created an issue.
Created Patch for the above issue;
pravesh_poonia → created an issue.
Created Patch for the above issue:
pravesh_poonia → created an issue.
Created Patch for above issue:
pravesh_poonia → created an issue.
Created Patch for the above issue:
pravesh_poonia → created an issue.
Upgrade PHPUnit to version 10 and consider dropping the Symfony PHPUnit-bridge dependency due to compatibility issues and potential future changes in Symfony's support for PHPUnit. As the current tech gap in our testing suite, especially with PHPUnit 11 released, necessitates action.
composer require --dev phpunit/phpunit ^10
composer remove --dev symfony/phpunit-bridge
Resolve the issue with ParamConverterManager's lazy services by implementing a service locator approach. Currently, services tagged 'paramconverter' are declared as lazy but are instantiated early during ParamConverterManager construction, leading to performance issues. To address this, convert ParamConverterManager to utilize a service locator, ensuring paramconverter services are lazily loaded only when required by a route. Additionally, remove the lazy proxy services for paramconverter services to streamline the process and improve performance
Resolve 'Drupal.Commenting.TodoComment' coding standard issue by following the correct @todo formatting guidelines, Ensure that sentences following '@todo' are capitalized. Run code style checks with fixing enabled and commit the patch for consistency and compliance with Drupal coding standar
Update user_login_finalize(&$form_state) documentation to accurately reflect its parameter. Similarly, revise hook_user_login(&$edit, $account, $category) to clarify that $edit pertains to $form_state. These changes ensure consistency and accuracy in understanding and using these functions
Replace $(window).on('dialog:beforecreate') with window.addEventListener('dialog:beforecreate').
While $(window).on('dialog:EVENTTYPE') remains backward compatible, listeners will receive deprecation messages. Additionally, a deprecation script checks if the old dialog:beforecreate is present in $._data(window, 'events'), triggering a deprecation message if found."
But checked MR, changes looking fixed now
Updating PHPUnit compatibility due to the deprecation in version 10.5.18, which now requires string array keys in data sets returned by data provider methods to match parameter names in Kernel tests. This change ensures continued compatibility with the latest PHPUnit version and maintains best practices for data provider usage
Yes, Issue is fixed now
"Updating PHPUnit 10 compatibility in MarkupInterfaceComparatorTest by replacing catch of PHPUnit\Framework\Error\Warning with appropriate replacements. Refactoring of runtime code is needed to eliminate trigger_error() calls as part of this process."
Considering the deprecation message indicating an error in Drupal 11, it's prudent to address this now. How about implementing the suggested change in a separate MR for version 10.3? This approach ensures compatibility with future Drupal versions while maintaining stability for the current release
Agreed with Berdir's assessment that this fix meets the criteria for 'no tests needed.' Since it's a straightforward one-liner without introducing new code branches, additional tests would involve duplicating schema content unnecessarily. Given that this issue is specific to older versions and won't impact Drupal 11.x, test coverage is deemed unnecessary
Applied MR, changes looking fixed now
Issue looks like fixed now
yes, issues are looking fixed now
Applied Patch, Issue is looking fixed now
Applied MR, changes are looking Fixed now
Applied MR !7628, changes are looking correct now
Applied MR-7572, it looks correct now
It is looking better now and Test time is also taking less time compared to before
Yes, Issues are looking Fixed now
Apllied patch, changes are looking correct to me, seems like everything is working as expected now.
@smustgrave, Applied mr changes are looking good to me, @
lobodakyrylon you can check it is good to go
@wotnak, changes are looking fine to me
@justafish, you can check and close the issue
@kostyashupenko Tested Merge request !6957, changes are showing correct
@heykarthikwithu, Gautam_105@ On applying #7 MR, changes look fine to me
Moving ti RTBC
Applied MR 6753, Mentioned issue fixed
@Shweta__sharma Checked this issue after applying changes, issue fixed
Applies patch, after adding 'core/once' in dependencies, Issue is getting fixed
Mentioned issue fixed and created MR
Pravesh_Poonia → made their first commit to this issue’s fork.
Mentioned issue fixed and created MR
1) Need to Add Main Navigation in Main Navigation Region in Block Layout
2) Need to Add in Logo in Site Branding Region in Block Layout
Adding screenshots for reference
Pravesh_Poonia → made their first commit to this issue’s fork.
Updated MR, Issue fixed
MR Pipeline passed now
Mentioned issue fixed and created MR
Pravesh_Poonia → made their first commit to this issue’s fork.
Issue fixed and create MR for issue
Pravesh_Poonia → made their first commit to this issue’s fork.
Pravesh_Poonia → created an issue.
Pravesh_Poonia → created an issue.
Pravesh_Poonia → created an issue.
Pravesh_Poonia → created an issue.
Pravesh_Poonia → created an issue.
Pravesh_Poonia → created an issue.
Pravesh_Poonia → created an issue.